Issue-184/integrate-golanglint-only

[AugustasV]

Summary

#184 Only integrated Golangci-lint. I am not able to fix those linter errors, it's just too much of them ( deadcode, errcheck, golint, gosec and others) only fixed some whitespaces

Ticket Link

Integrate Golangci-lint #184

[mattermod]

Hello @AugustasV,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[codecov-io]

Codecov Report

Merging #196 (6ba595f) into master (50beb11) will increase coverage by 0.25%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   23.05%   23.30%   +0.25%     
==========================================
  Files          64       64              
  Lines        2316     2291      -25     
==========================================
  Hits          534      534              
+ Misses       1703     1679      -24     
+ Partials       79       78       -1     

Impacted Files	Coverage Δ
server/command/command.go	39.02% <0.00%> (ø)
server/command/create_event.go	0.00% <0.00%> (ø)
server/command/unsubscribe.go	0.00% <0.00%> (ø)
server/mscalendar/auto_respond.go	62.96% <ø> (ø)
server/mscalendar/availability.go	55.55% <ø> (ø)
server/mscalendar/calendar.go	0.00% <0.00%> (ø)
server/mscalendar/event_responder.go	0.00% <0.00%> (ø)
server/mscalendar/filters.go	39.13% <ø> (+3.13%)	⬆️
server/mscalendar/mscalendar.go	100.00% <ø> (ø)
server/mscalendar/settings.go	0.00% <0.00%> (ø)
... and 15 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50beb11...6ba595f. Read the comment docs.

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich

[jasonblais]

@hanzei @jfrerich what would be a good way to proceed?

[hanzei]

Talked with @AugustasV offline. He will disable the failing linters for now.

[AugustasV]

@hanzei sure right now build is successful.

[jasonblais]

@mickmister kind reminder to help with a review :)

[mickmister]

Awesome work @AugustasV! I have some questions about the Makefile, and a request to group/order package imports if they are from a mattermost repo.

[mickmister]

LGTM thanks @AugustasV!

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

[hanzei]

@DHaussermann Not sure what to test for this PR. It mostly contains build changes.

[DHaussermann]

@AugustasV I don't see any lint errors here but I do see what looks like a change in behavior here. if I just type make I see

➜  mattermost-plugin-mscalendar git:(AugustasV-master) ✗ make
go install github.com/golang/mock/mockgen
mockgen -destination server/jobs/mock_cluster/mock_cluster.go github.com/mattermost/mattermost-plugin-api/cluster JobPluginAPI
mockgen -destination server/mscalendar/mock_mscalendar/mock_mscalendar.go github.com/mattermost/mattermost-plugin-mscalendar/server/mscalendar MSCalendar
mockgen -destination server/mscalendar/mock_welcomer/mock_welcomer.go -package mock_welcomer github.com/mattermost/mattermost-plugin-mscalendar/server/mscalendar Welcomer
mockgen -destination server/mscalendar/mock_plugin_api/mock_plugin_api.go -package mock_plugin_api github.com/mattermost/mattermost-plugin-mscalendar/server/mscalendar PluginAPI
mockgen -destination server/remote/mock_remote/mock_remote.go github.com/mattermost/mattermost-plugin-mscalendar/server/remote Remote
mockgen -destination server/remote/mock_remote/mock_client.go github.com/mattermost/mattermost-plugin-mscalendar/server/remote Client
mockgen -destination server/utils/bot/mock_bot/mock_poster.go github.com/mattermost/mattermost-plugin-mscalendar/server/utils/bot Poster
mockgen -destination server/utils/bot/mock_bot/mock_admin.go github.com/mattermost/mattermost-plugin-mscalendar/server/utils/bot Admin
mockgen -destination server/utils/bot/mock_bot/mock_logger.go github.com/mattermost/mattermost-plugin-mscalendar/server/utils/bot Logger
mockgen -destination server/store/mock_store/mock_store.go github.com/mattermost/mattermost-plugin-mscalendar/server/store Store

and then it stops it does not go on to run unit test and build the binary. There are no issues when I type make all any thoughts on what could cause this change or if it's an issue?

cc @hanzei

[hanzei]

@DHaussermann For plugin that have a custom makefile at build/custom.mk make will always run the first command in the custom makefile. This is the expected behaviour in this case. The command you are looking for is make all.

[DHaussermann]

Thanks @hanzei I figured it may not be an issue that you have to use make all and not just make But it felt odd to me that on master branch this behavior is different. Does this also make sense to you?

[hanzei]

Yes. This PR was the one that introduced build/custom.mk.

[DHaussermann]

Tested and passed

No issues will build or deployment.
LGTM!

Thanks @AugustasV for adding this! Much appreciated.