Fix findmeetings typo

[MatthewDorner]

Summary

There is a typo in the autocomplete description for the /mscalendar command, and since the command is case-sensitive it will not work if typed as shown. It should be findmeetings. I didn't find any other instances of this typo in the repository.

[hanzei]

Good catch 👍

[hanzei]

@mickmister I noticed that some of the commands found in https://github.com/mattermost/mattermost-plugin-mscalendar/blob/master/server/command/command.go#L61-L88 are not listed in the hint. Should they be added?

[mickmister]

@hanzei Yes, it seems disconnect, connect_bot, and disconnect_bot are missing. testcreateevent should be listed as createevent, as well.

@MatthewDorner Do you mind including these in your changes here?

[MatthewDorner]

There is no help command either, or descriptions of the parameters the subcommands accept such as subscribe list | show | renew | delete .

[mickmister]

@MatthewDorner How about something like this:

subscribe (list | show | renew | delete), ...

These would also need to show up in the output of /mscalendar help.

We can break this out into a separate ticket since it is growing in scope. What do you think @MatthewDorner?

[MatthewDorner]

We can make it a separate issue. I will just add the missing commands for this PR.

[MatthewDorner]

There is a getHelp() placeholder function in command.go:

mattermost-plugin-mscalendar/server/command/command.go

Line 29 in 864a161

func getHelp() string {

This led me to think there was no help text, but actually it's just implemented elsewhere in command/help.go (even though it needs to be updated as noted in this thread).

Anyway if getHelp() won't be used, maybe it should be removed from the code.

[mickmister]

@MatthewDorner I think it makes sense to have getHelp() implement the help text, and have c.help call getHelp() in order to use the help text. I'll use this info in the followup ticket.

[mickmister]

LGTM

[larkox]

Sounds nice. Nevertheless, (and probably out of the scope of this PR) what about making the commands case-insensitive? It would mean just a strings.ToLower before the switch.

[mickmister]

Tested, this works