Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the initial skel for using playwright + testcontainers #459

Closed
wants to merge 8 commits into from
Closed

Adding the initial skel for using playwright + testcontainers #459

wants to merge 8 commits into from

Conversation

jespino
Copy link
Member

@jespino jespino commented Dec 28, 2023

No description provided.

@jespino
Copy link
Member Author

jespino commented Dec 28, 2023

@saturninoabril maybe this is something interesting for other environments. I'm using playwright in combination with testcontainers to be able to run e2e tests in a very controlled way. Let me know if you find this useful and we can talk more in detail about it.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (55a01bf) 43.45% compared to head (10d0045) 43.45%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage   43.45%   43.45%           
=======================================
  Files          21       21           
  Lines        6289     6289           
=======================================
  Hits         2733     2733           
  Misses       3331     3331           
  Partials      225      225

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saturninoabril
Copy link
Member

Thanks @jespino! First time to hear testcontainers but looks really interesting! Will watch out on how this is going and will see if this is something we can adopt for our other test environments, cc @mvitale1989 @toninis @phoinixgrr

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 4, 2024
View reviewed changes
playwright/mmcontainer.ts Dismissed Show dismissed Hide dismissed
lieut-data
lieut-data approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to start building on this!

playwright/tests-examples/demo-todo-app.spec.ts
@@ -0,0 +1,437 @@
import { test, expect, type Page } from '@playwright/test';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this demo file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, for sure.

@panoramix360 panoramix360 mentioned this pull request Feb 12, 2024
Open
@lieut-data lieut-data added this to the v1.9.0 milestone Feb 20, 2024
@lieut-data lieut-data modified the milestones: v1.9, v1.10 Mar 3, 2024
@lieut-data lieut-data removed this from the v1.10 milestone Mar 18, 2024
@lieut-data
Copy link
Member

Closing old PRs for now, can revisit as we have bandwidth.

@lieut-data lieut-data closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lieut-data lieut-data lieut-data approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jespino @codecov-commenter @saturninoabril @lieut-data