[GH-20818] - Add restore run feature for playbook #1448
Conversation
* There was a /restore feat already present in the repo * created a api request in client.ts * added a hook in restore_run.tsx * Added menu in button in context_menu.tsx and called the hook on button click. Resolves #20818 - on github
|
Hello @rolwin100, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
There was a problem hiding this comment.
Overall LGTM! Great work on @rolwin100!! 🎉
Couple changes required.
My question here is whether this is restoring or restarting the run. Will the run pick up where it was left off (ie, any already completed steps will still be completed) or will this act more like it's a fresh new run?
Depending on which this is, I think it's important to ensure that all verbiage (things displayed to user, as well as file names/function names/etc) is consistently either restore or restart to avoid confusion.
webapp/src/components/backstage/playbook_runs/playbook_run/restore_run.tsx
Outdated
Show resolved
Hide resolved
|
👋 Hi @rolwin100, thanks for taking on this PR! I noticed that the original issue mentioned
Could you confirmed if that was something already implemented or if it's expected as part of this PR, please? |
|
@itao Its'a part of this PR. |
|
@nickmisasi regarding your question whether this is restoring or restarting the run. Yes, the run will pick up where it was left off. However I prefer the copy
|
@itao @nickmisasi can we proceed with the existing change as of now if it is okay with you people because the API which was present was named restore and I don't see much problem with this. What do you guys think? |
There was a problem hiding this comment.
Great work, @rolwin100! Thanks! I left two optional suggestions.
webapp/src/components/backstage/playbook_runs/playbook_run/restore_run.tsx
Outdated
Show resolved
Hide resolved
webapp/src/components/backstage/playbook_runs/playbook_run/restore_run.tsx
Outdated
Show resolved
Hide resolved
rolwin100
requested review from
nickmisasi
and removed request for
lieut-data,
crspeller,
Phrynobatrachus and
calebroseland
|
@rolwin100, great work on tests; thanks again! We will be able to merge this PR after the second reviewer approves it. |
There was a problem hiding this comment.
Code LGTM. Will need tests to pass before approval. Thanks @rolwin100 🎉!
* master: (25 commits) migrate fa icons to compass + fix pb assign owner clear (#1462) [GH-20818] - Add restore run feature for playbook (#1448) datetime selector: set custom error text (#1459) remove negative letter spacing and set wider min-width for context menu at PBE (#1453) Fix playbooks list refresh issue (#1436) RHS: do not trigger inline edit if user is doing a text-selection (#1452) remove rounded edges in add-new-task button (#1450) MM-45933: Playbook List Columns: Last used, Active runs, Runs in 30 days (#1360) add hover background color to pbe broadcast channel selector (#1451) Switch model for versioning golangci-lint (#1425) [MM-44815] Duplicate task as next task instead of the last task (#1430) [MM-45741] Add following button to runs list (#1370) Mm 46379 fav run in LHS queries (#1437) fix type for globalstate -> fix CI (#1447) Add channel scheme role support (#1431) avoid requiring permission for leaving a playbook (#1439) [MM-37996] create the new modal UI for the playbook run dialog (#1245) MM-43277: fix channel actions modal dropdown cutoffs/overflows (#1418) Translated using Weblate (Swedish) Translated using Weblate (Swedish) ...
* master: migrate md icons to compass (#1460) Fix OpenAPI spec, so it validates as OpenAPI v3; Switch http links to https links in schema examples (#1438) Mm 44752 add dot menu to lhs (#1458) migrate fa icons to compass + fix pb assign owner clear (#1462) [GH-20818] - Add restore run feature for playbook (#1448) datetime selector: set custom error text (#1459) remove negative letter spacing and set wider min-width for context menu at PBE (#1453) Fix playbooks list refresh issue (#1436) RHS: do not trigger inline edit if user is doing a text-selection (#1452) remove rounded edges in add-new-task button (#1450) MM-45933: Playbook List Columns: Last used, Active runs, Runs in 30 days (#1360) add hover background color to pbe broadcast channel selector (#1451) Switch model for versioning golangci-lint (#1425) [MM-44815] Duplicate task as next task instead of the last task (#1430) [MM-45741] Add following button to runs list (#1370)
* master: Separate run participants base (#1440) Tsprune (#1461) migrate md icons to compass (#1460) Fix OpenAPI spec, so it validates as OpenAPI v3; Switch http links to https links in schema examples (#1438) Mm 44752 add dot menu to lhs (#1458) migrate fa icons to compass + fix pb assign owner clear (#1462) [GH-20818] - Add restore run feature for playbook (#1448)
* master: limit size for all incoming requests and migrate postgres text column (#1463) wait() more :| (#1468) [MM-45662] Fix context dropdown closing when clicked (#1467) Separate run participants base (#1440) Tsprune (#1461) migrate md icons to compass (#1460) Fix OpenAPI spec, so it validates as OpenAPI v3; Switch http links to https links in schema examples (#1438) Mm 44752 add dot menu to lhs (#1458) migrate fa icons to compass + fix pb assign owner clear (#1462) [GH-20818] - Add restore run feature for playbook (#1448) datetime selector: set custom error text (#1459)
Summary
Ticket Link
mattermost/mattermost#20818
Checklist
Telemetry updatedGated by experimental feature flag