Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1765 Fix editor background and header issue #1799

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

m-ripper
Copy link
Contributor

@m-ripper m-ripper commented Feb 2, 2023

Summary

Fix background not spanning whole content and header disappearing due to that.

Screencast.from.02.02.2023.14.07.19.webm

Ticket Link

Fixes #1765

Checklist

  • Telemetry updated
  • Gated by experimental feature flag
  • Unit tests updated

@m-ripper m-ripper added the 2: Dev Review Requires review by a core committer label Feb 2, 2023
@m-ripper m-ripper added this to the v7.8 (February 2023) milestone Feb 2, 2023
Copy link
Member

@calebroseland calebroseland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One-liner CSS fixes are especially nice 🙂

@calebroseland calebroseland added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Feb 2, 2023
@calebroseland calebroseland merged commit 49196b3 into master Feb 2, 2023
@calebroseland calebroseland deleted the gh-1765-fix-editor-background-and-header branch February 2, 2023 16:10
trilopin added a commit that referenced this pull request Feb 7, 2023
* master:
  Disable button to start a run while request has not received a response (#1794)
  GH-1767 Default to current channel when linking a new playbook run (#1795)
  GH-1774 Localize timeline events (#1787)
  GH-1768 Localize retrospective interval options (#1793)
  GH-1765 Fix editor background and header issue (#1799)
  GH-1772 Update LHS when duplicating playbook (#1785)
trilopin added a commit that referenced this pull request Feb 7, 2023
* master:
  Disable button to start a run while request has not received a response (#1794)
  GH-1767 Default to current channel when linking a new playbook run (#1795)
  GH-1774 Localize timeline events (#1787)
  GH-1768 Localize retrospective interval options (#1793)
  GH-1765 Fix editor background and header issue (#1799)
  GH-1772 Update LHS when duplicating playbook (#1785)
@calebroseland calebroseland removed this from the v7.8 (February 2023) milestone Feb 8, 2023
trilopin added a commit that referenced this pull request Feb 13, 2023
* master:
  upgrade golangci version to 1.51.1 (#1797)
  fix e2e selectors after post migration (#1798)
  Disable button to start a run while request has not received a response (#1794)
  GH-1767 Default to current channel when linking a new playbook run (#1795)
  GH-1774 Localize timeline events (#1787)
  GH-1768 Localize retrospective interval options (#1793)
  GH-1765 Fix editor background and header issue (#1799)
  GH-1772 Update LHS when duplicating playbook (#1785)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playbook sidebar scrolling & background issues
2 participants