Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hello world http method #13

Merged
merged 2 commits into from Oct 10, 2018
Merged

Add hello world http method #13

merged 2 commits into from Oct 10, 2018

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Oct 2, 2018

This PR adds a hello world http method to the plugin. It also, and I think this more important, adds a test for this.

@jwilander jwilander added the 2: Dev Review Requires review by a core committer label Oct 10, 2018
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanzei, thanks for this! Given the broad spectrum of potential "hello world"-style plugins (hooks, API calls, etc.), thus far we have been targeting https://github.com/mattermost/mattermost-plugin-demo for demos of how to actually write (parts of) a plugin.

This repository is primarily meant as a starting point for a "plugin from scratch", with the minimum necessary (build tooling, configuration handling) to remove before writing your own plugin, enabling a fast clone/copy to get a template.

That being said, I think this is the perfect balance between "sample" and "demo", and I'm in favour of adding, especially as it illustrates how to write unit tests for your ensuing plugin with a minimum of code.

Adding @hmhealey for some additional developer review, but otherwise LGTM :)

Copy link
Member

@hmhealey hmhealey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lieut-data lieut-data added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Oct 10, 2018
@lieut-data lieut-data merged commit b9e17a1 into mattermost:master Oct 10, 2018
@hanzei hanzei deleted the http branch October 10, 2018 14:46
mickmister pushed a commit to mickmister/mattermost-plugin-sample that referenced this pull request Jun 24, 2019
Add check-style makefile target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants