Make unhandled webhook events return 200 instead of 501 (#257)

mattermost · Apr 13, 2022 · a986bb4 · a986bb4
1 parent 8a5a54d
commit a986bb4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/server/http.go b/server/http.go
@@ -231,7 +231,7 @@ func (p *Plugin) handleWebhook(w http.ResponseWriter, r *http.Request) {
 	}
 
 	if webhook.Event != zoom.EventTypeMeetingEnded {
-		w.WriteHeader(http.StatusNotImplemented)
+		w.WriteHeader(http.StatusOK)
 		return
 	}
 

diff --git a/server/plugin_test.go b/server/plugin_test.go
@@ -92,7 +92,7 @@ func TestPlugin(t *testing.T) {
 		},
 		"ValidStartedWebhookRequest": {
 			Request:                validStartedWebhookRequest,
-			ExpectedStatusCode:     http.StatusNotImplemented,
+			ExpectedStatusCode:     http.StatusOK,
 			HasPermissionToChannel: true,
 		},
 		"NoSecretWebhookRequest": {