Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use to CSRF Header or Form Field #26

Closed
hanzei opened this issue Jun 4, 2019 · 7 comments
Closed

Use to CSRF Header or Form Field #26

hanzei opened this issue Jun 4, 2019 · 7 comments
Labels
Help Wanted Community help wanted

Comments

@hanzei
Copy link
Collaborator

hanzei commented Jun 4, 2019

On MM master pressing the start meeting button throws an error in the system log:
CSRF Check failed for request - Please migrate your plugin to either send a CSRF Header or Form Field, XMLHttpRequest is deprecated
@hanzei hanzei added the bug label Jun 4, 2019
@jasonblais
Copy link
Contributor

@hanzei Possibly related to https://mattermost.atlassian.net/browse/MM-15783

@hanzei hanzei added the Triage label Jun 21, 2019
@crspeller
Copy link
Member

Those changes should help. But the zoom plugin still needs to use Client4.getOptions like other plugins do.

@levb levb added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Needs Spec Needs further specification to be a good (help wanted) ticket and removed Triage labels Oct 1, 2019
@levb
Copy link
Contributor

levb commented Oct 1, 2019

@crspeller can you please provide a link to an example?

@crspeller
Copy link
Member

Jira plugin: https://github.com/mattermost/mattermost-plugin-jira/blob/512408ed5cab1238ebe4b718f2120047384d5ac0/webapp/src/client/index.js#L14

@hanzei hanzei removed the Needs Spec Needs further specification to be a good (help wanted) ticket label Oct 3, 2019
@bolariin
Copy link
Contributor

I think #51 might have resolved this issue

@jasonblais
Copy link
Contributor

I think #51 might have resolved this issue

Pinging @mickmister and @crspeller to confirm after the holidays

@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Dec 27, 2019
@crspeller
Copy link
Member

Confirmed. Fixed by #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted Community help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@levb @crspeller @jasonblais @hanzei @bolariin