Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs link in plugin.json #318

Merged
merged 2 commits into from Nov 7, 2023
Merged

Update docs link in plugin.json #318

merged 2 commits into from Nov 7, 2023

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Nov 6, 2023

@hanzei hanzei added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core committer labels Nov 6, 2023
@hanzei hanzei requested a review from cwarnermm November 6, 2023 10:56
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8de3a8) 19.33% compared to head (d367ff2) 19.33%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   19.33%   19.33%           
=======================================
  Files           9        9           
  Lines        1479     1479           
=======================================
  Hits          286      286           
  Misses       1138     1138           
  Partials       55       55

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cwarnermm
cwarnermm approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hanzei!

@cwarnermm cwarnermm removed the 1: PM Review Requires review by a product manager label Nov 6, 2023
mickmister
mickmister approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mickmister mickmister added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 7, 2023
@mickmister
Copy link
Member

I confirmed that going to that link takes you to the admin guide part of the readme

@hanzei hanzei merged commit 6813e92 into master Nov 7, 2023
11 checks passed
@hanzei hanzei deleted the hanzei-patch-1 branch November 7, 2023 08:30
@hanzei hanzei added this to the v2.0.0 milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickmister mickmister mickmister approved these changes

@cwarnermm cwarnermm cwarnermm approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hanzei @mickmister @cwarnermm