Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating dependencies. #32

Merged
merged 1 commit into from Jul 8, 2019
Merged

Updating dependencies. #32

merged 1 commit into from Jul 8, 2019

Conversation

crspeller
Copy link
Member

No description provided.

@crspeller crspeller added the 2: Dev Review Requires review by a core committer label Jul 8, 2019
@crspeller crspeller requested review from jfrerich, hanzei and cpoile and removed request for hanzei July 8, 2019 17:58
jfrerich
jfrerich approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but have a general question. What is the actual code or package change that requires adding all the new dependencies? Is the upgrade from mm-server v0.0.0 to mm-server v5.12.0 the cause?

@crspeller
Copy link
Member Author

@jfrerich It's not that anything was added. Whoever created the mod files didn't run go mod tidy.

@cpoile cpoile merged commit c1bdfe2 into master Jul 8, 2019
@cpoile cpoile added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jul 8, 2019
@crspeller crspeller deleted the update-deps branch July 9, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpoile cpoile cpoile approved these changes

@jfrerich jfrerich jfrerich approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crspeller @cpoile @jfrerich