Add version flag and build amd64 and arm64 targets #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gibing some love to this project and also preparing to the ownership migration to cloud sre team, that will run push proxy in a container, so preparing all the autobahn for future usage |
enahum
reviewed
Oct 19, 2021
enahum
reviewed
Oct 19, 2021
enahum
approved these changes
Oct 19, 2021
cpanato
force-pushed
the
version
branch
13 times, most recently
from
61cbd41
to
e412903
Compare
spirosoik
reviewed
Oct 25, 2021
|
|
||
| package-linux-amd64: |
There was a problem hiding this comment.
better to make this a script and just change the flags accordingly so it can be repeatable and avoid copy/paste in two places in case we change something?
There was a problem hiding this comment.
agree, maybe we can do in a follow up
spirosoik
approved these changes
Oct 25, 2021
cpanato
added
2: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
version demo:
$ ./bin/mattermost-push-proxy --version GitVersion: v5.22.5-7-g35e4ca9 GitCommit: 35e4ca962a1a44b151387e27455b3bf013b711fe GitTreeState: clean BuildDate: '2021-10-19T12:33:02Z' GoVersion: go1.17.2 Compiler: gc Platform: darwin/amd64Ticket Link
JIRA https://mattermost.atlassian.net/browse/DOPS-22