Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Without chrome extension Redux Dev Tools the webapp throws errors #354

Closed
watadarkstar opened this issue Dec 13, 2017 · 4 comments
Closed

Comments

@watadarkstar
Copy link
Contributor

Summary

If you don't have the chrome extension Redux Dev Tools installed you get a whole bunch of errors (see below) that cause the webapp to "explode" in development.

image pasted at 2017-12-13 10-28

Environment Information

  • Webapp: ?
  • Mattermost Server Version: ?

Steps to reproduce

Install the webapp dev environment without Redux Dev Tools installed.

Expected behavior

Would be nice to have this disabled by default and or more gracefully handle these errors.

Observed behavior

Error messages (see screenshot above).

Possible fixes

In configureStore.dev.js there is a bunch of stuff regarding remote-redux-devtools. More specifically look into disabling the tools if window.__REDUX_DEVTOOLS_EXTENSION__ doesn't exist. See these lines of code:

typeof window !== 'undefined' && window.__REDUX_DEVTOOLS_EXTENSION__ ? // eslint-disable-line no-underscore-dangle
window.__REDUX_DEVTOOLS_EXTENSION__ : // eslint-disable-line no-underscore-dangle
() => {
return devTools({
name: 'Mattermost',
hostname: 'localhost',
port: 5678,
realtime: true
});

@hanzei
Copy link
Contributor

hanzei commented Nov 17, 2018

I can't reproduce this issue with Mattermost 5.5. Do this still occur @watadarkstar?

@watadarkstar
Copy link
Contributor Author

This is a really old issue @hanzei

@hanzei
Copy link
Contributor

hanzei commented Nov 18, 2018

Sure, I know. Mind if I close it?

@watadarkstar
Copy link
Contributor Author

Yup can be closed.

chetanyakan pushed a commit to brightscout-alpha/mattermost-redux that referenced this issue Feb 9, 2021
* Clarify what deleting a channel does

* Update teams.yaml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants