MM-13545 Removal of unused status flags in Schemes requests state object #1007
Conversation
| let data = null; | ||
| try { | ||
| data = await Client4.deleteScheme(schemeId); | ||
| } catch (error) { | ||
| forceLogoutIfNecessary(error, dispatch, getState); | ||
| dispatch(batchActions([ | ||
| {type: SchemeTypes.DELETE_SCHEME_FAILURE, error}, | ||
| logError(error), |
There was a problem hiding this comment.
@nadalfederer hey, Can you add the dispatch of logError back here? We still would like to keep those.
|
@nadalfederer everything looks good to me other than the one change request. |
There was a problem hiding this comment.
Tested and looks good, except for the comment from @sudheerDev.
|
@sudheerDev thanks for the review. I fixed it. Off-topic: there is a |
|
This issue has been automatically labelled "stale" because it hasn't had recent activity. /cc @jasonblais @hanzei |
|
/update-branch |
|
Error trying to update the PR. |
|
@sudheerDev quick reminder to help with reviews after the holidays, thanks! :) |
Thanks ok. It is fine to leave. We don't need to remove actions which are not used with this PR. @nadalfederer Hey, there are few conflicts. Can you resolve them so i can merge it?. Sorry about the delay, Somehow this was out of my review queue until jason requested again. |
sudheerDev
added
4: Reviews Complete
# Conflicts: # src/reducers/requests/index.ts # src/types/requests.ts # src/types/store.ts
hanzei
added
Awaiting Submitter Action
# Conflicts: # src/types/store.ts
|
@sudheerDev hi, I resolved conflicts |
Remove unused status flags from https://github.com/mattermost/mattermost-redux/blob/master/src/reducers/requests/schemes.js
Fixes mattermost/mattermost#13029
PR's for reference:
Redux PR: #748
Mobile PR: mattermost/mattermost-mobile#2490
Web PR: mattermost/mattermost-mobile#2496