This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Add initial JenkinsFile for redux #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieut-data
previously approved these changes
Jun 11, 2018
build/Jenkinsfile
Outdated
| tar -zxf mattermost-enterprise-linux-amd64.tar.gz | ||
|
|
||
| cd mattermost | ||
| sed -i'' 's|mmuser:mostest@tcp(dockerhost:3306)/mattermost_test?charset=utf8mb4,utf8|root:passwd@tcp(localhost:3306)/'${BUILD_TAG}'?charset=utf8mb4,utf8|g' config/config.json; |
There was a problem hiding this comment.
I suspect this is copied from other such files, but I wonder if we should adopt a less brittle approach and just export the desired variables to the environment vs. messing with the config.json syntax:
export MM_SQLSETTINGS_DATASOURCE="..."
export MM_TEAMSETTINGS_ENABLEOPENSERVER="true"
...
There was a problem hiding this comment.
done and thanks so much for this valuable info!
|
actually not! :) i will test and see any improvements/issues |
jwilander
previously approved these changes
Jun 12, 2018
jwilander
added
4: Reviews Complete
cpanato
dismissed stale reviews from lieut-data and jwilander
updates and new file
|
@lieut-data @jwilander PTAL, i've update based in the tests using the pipeline. however, to test using the real server we need to fix some tests it is failing in the beginning > mattermost-redux@1.2.0 test-no-mock /home/ubuntu/jenkins/workspace/mmrdx/test-pipe-redux
> TEST_SERVER=1 NOCK_OFF=true NODE_ENV=test mocha --opts test/mocha.opts
/home/ubuntu/jenkins/workspace/mmrdx/test-pipe-redux/test/test_helper.js:197
creator_id: _this.basicUser.id,
^
TypeError: Cannot read property 'id' of null
at TestHelper.testCommand (/home/ubuntu/jenkins/workspace/mmrdx/test-pipe-redux/test/test_helper.js:194:40)
at Suite.<anonymous> (/home/ubuntu/jenkins/workspace/mmrdx/test-pipe-redux/test/selectors/integrations.test.js:22:66)
at Object.create (/home/ubuntu/jenkins/workspace/mmrdx/test-pipe-redux/node_modules/mocha/lib/interfaces/common.js:112:19)
at context.describe.context.context (/home/ubuntu/jenkins/workspace/mmrdx/test-pipe-redux/node_modules/mocha/lib/interfaces/bdd.js:44:27)
at Object.<anonymous> (/home/ubuntu/jenkins/workspace/mmrdx/test-pipe-redux/test/selectors/integrations.test.js:10:1)
at Module._compile (module.js:652:30)
at loader (/home/ubuntu/jenkins/workspace/mmrdx/test-pipe-redux/node_modules/babel-register/lib/node.js:144:5)
at Object.require.extensions.(anonymous function) [as .js] (/home/ubuntu/jenkins/workspace/mmrdx/test-pipe-redux/node_modules/babel-register/lib/node.js:154:7)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
at /home/ubuntu/jenkins/workspace/mmrdx/test-pipe-redux/node_modules/mocha/lib/mocha.js:253:27
at Array.forEach (<anonymous>)
at Mocha.loadFiles (/home/ubuntu/jenkins/workspace/mmrdx/test-pipe-redux/node_modules/mocha/lib/mocha.js:250:14)
at Mocha.run (/home/ubuntu/jenkins/workspace/mmrdx/test-pipe-redux/node_modules/mocha/lib/mocha.js:577:10)
at Object.<anonymous> (/home/ubuntu/jenkins/workspace/mmrdx/test-pipe-redux/node_modules/mocha/bin/_mocha:591:18)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Function.Module.runMain (module.js:693:10)
at startup (bootstrap_node.js:191:16)
at bootstrap_node.js:612:3
npm ERR! code ELIFECYCLE |
lieut-data
approved these changes
Jun 13, 2018
|
ok, then I will comment the part that tests using a live server. ok @lieut-data ? |
|
I'm personally ok with that! @jwilander, any objections? |
|
Yes that's good with me 👍 |
|
@jwilander @lieut-data set only the master branch to run the tests with a live server. |
jwilander
approved these changes
Jun 18, 2018
|
@cpanato feel free to merge |
chetanyakan
pushed a commit
to brightscout-alpha/mattermost-redux
that referenced
this pull request
Feb 9, 2021
…oup in the users api (mattermost#528)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to test I need get this merged :)
Ticket Link
jira: https://mattermost.atlassian.net/browse/MM-7495