This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
MM-14897: Changes to be able to add and remove groups from channels. #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkraft
force-pushed
the
MM-14410
branch
2 times, most recently
from
ae056bd
to
0fd0d3e
Compare
mkraft
added
2: Dev Review
mkraft
added
the
Do Not Merge/Awaiting PR
jespino
reviewed
May 14, 2019
src/selectors/entities/groups.js
Outdated
| @@ -51,6 +51,11 @@ function getTeamGroupIDSet(state, teamID) { | |||
| return new Set(arr); | |||
| } | |||
|
|
|||
| function getChannelGroupIDSet(state, channelID) { | |||
There was a problem hiding this comment.
this selector will every single time generate a new object, we could create a function for the array, and a selector (based on that function) for the set, that way, if the underneath array hasn't change, the set will be cached.
jespino
suggested changes
May 14, 2019
mgdelacroix
approved these changes
May 14, 2019
…-associated) to teams.
Co-Authored-By: mkraft <martin@upspin.org>
jespino
added
4: Reviews Complete
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change to be able to add and remove groups from channels.
This is pretty much the same thing as #821, but for channels.
Relies on: mattermost/mattermost#10794
Ticket Link
https://mattermost.atlassian.net/browse/MM-14897
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit tests passedmake flowto ensure type checking passedTest Information
Chrome browser, macOS.