This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Pin version of serialize-error to 2.1.0 #984
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a node library and later versions use node packages (e.g. `util`). We've had to do this once before in #822 .
chuttam
commented
Nov 13, 2019
| @@ -22,7 +22,7 @@ export function dismissError(index: number): ActionFunc { | |||
| }; | |||
| } | |||
|
|
|||
| export function getLogErrorAction(error: ErrorObject, displayable = false) { | |||
| export function getLogErrorAction(error: any, displayable = false) { | |||
There was a problem hiding this comment.
Setting type to any fixes the problem, and the resultant, tsc "compiled" code successfully resolves the desired type to serializeError.ErrorObject.
However changing the any to error: serializeError.ErrorObject fails because v2.1.0 of serializer-error doesn't export ErrorObject.
Could someone with stronger TypeScript fu than me perhaps guide how to create/export an explicit type definition that matches the structure of ErrorObject below?
export type ErrorObject = {
name?: string;
stack?: string;
message?: string;
code?: string;
}
|
Closing, since it's already handled by mattermost/mattermost-mobile#3553 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Put
serialize-errorback to version 2.1.0. It's a node library and later versions use node packages (e.g.util).Ticket Link
Fixes #983
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit tests passedTest Information
This PR was tested on: iPhone X (simulator)
We've had to do this once before in #822 , but this new attempt is a tiny bit more involved because of type checking rules. The PR does introduce an explicit
anyusage, which compiles down to the correctserializeError.ErrorObjecttype.