Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests from "utils/lru_test.go" and "utils/test_files_compiler.go" to use testify #12885

Closed
mattermod opened this issue Oct 23, 2019 · 1 comment · Fixed by #12899
Closed
Assignees
Labels
Area/Technical Debt Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted PR Exists Tech/Go Server

Comments

@mattermod
Copy link
Contributor

mattermod commented Oct 23, 2019

Mattermost is migrating its server tests from using the t.Fatal method calls on their checks to use the testify toolkit. The goal of this migration is to improve the readability of the tests, making them more concise and meaningful. This Help Wanted issue is to migrate the tests in the utils/lru_test.go and utils/test_files_compiler.go files.

The expected way to migrate this is to go to the utils/lru_test.go and utils/test_files_compiler.go files and modify the calls to t.Fatal and the condition checks that lead to them, replacing them with calls to the the require package if a failure should stop the execution of the test, or the assert package if it shouldn't.

Example: #12039

If you have questions about the ticket or you need any help, feel free to contact miguel.delacruz or jesus.espino in https://community.mattermost.com/


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-19668

@mgdelacroix mgdelacroix added Area/Technical Debt Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Tech/Go Server labels Oct 23, 2019
@a8uhnf
Copy link
Contributor

a8uhnf commented Oct 23, 2019

I'll take this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/Technical Debt Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted PR Exists Tech/Go Server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants