Convert app/webhook_test.go t.Fatal calls into assert/require calls #12039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespino
added
2: Dev Review
jwilander
requested review from
mgdelacroix
and removed request for
jwilander
|
Adding @mgdelacroix as he put his name to own the campaign around these changes |
jespino
commented
Sep 3, 2019
mgdelacroix
requested changes
Sep 4, 2019
lieut-data
approved these changes
Sep 4, 2019
lindalumitchell
removed
the
3: QA Review
This was referenced Sep 5, 2019
This was referenced Oct 15, 2019
This was referenced Oct 22, 2019
Closed
|
I cant seem to find the file webhooks_test.go. Or am i missing something? |
|
@QamarFarooq it is actually named |
hanzei
changed the title
Good catch. It should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert app/webhooks_test.go t.Fatal calls into assert/require calls
Ticket Link
MM-18207