Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel sidebar should push content over, rather than slide on top to follow native iOS design #12901

Closed
esethna opened this issue Oct 23, 2019 · 2 comments · Fixed by mattermost/mattermost-mobile#3622
Assignees
Labels

Comments

@esethna
Copy link
Contributor

esethna commented Oct 23, 2019

Expected (See Mail and Slack sidebars): Post list content is pushed right when the sidebar opens. The sidebar is underneath (lower vertical height) the post list - see Mail or Slack apps for examples of this native behaviour. In addition, tapping, holding and sliding your finger to the right anywhere on the post list content should start opening the sidebar.

sidebar

Observed: The sidebar pulls out over top of the content when swiping only from the edge of the screen. See video in ticket

Note that on Android the sidebar should behave as it does now (does not push the content over). This is only a change for iOS to behave more natively.


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-18530

@esethna esethna changed the title Channel sidebar should push content over, rather than slide on top to follow native design Channel sidebar should push content over, rather than slide on top to follow native iOS design Oct 23, 2019
@nick-brady
Copy link

Hey there! I started this today and progress was pretty smooth. I still need to clean up the code and do some testing, but I should be able to make a PR soon.

One note, about this:

In addition, tapping, holding and sliding your finger to the right anywhere on the post list content should start opening the sidebar.

the "swipe anywhere" is really a separate task, and I found this issue here which covers it. My PR addresses the first part of this ticket, which would be changing iOS behavior to have the content move over the sidebar.

@migbot
Copy link
Contributor

migbot commented Nov 26, 2019

Thanks @nick-brady!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants