Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate 'components/announcement_bar/version_bar' module and associated tests to TypeScript #16167

Closed
1 task
mattermod opened this issue Oct 29, 2020 · 1 comment · Fixed by mattermost/mattermost-webapp#6976
Assignees

Comments

@mattermod
Copy link
Contributor

We are starting to migrate the mattermost-webapp over to TypeScript to facilitate better code quality. This Help Wanted issue is to modify all files in components/announcement*bar/version*bar (not sub-directories included) and associated test files.

Below is a checklist of items you should be doing to migrate:

  • < ] Rename the files to their associated TypeScript extensions (ie. js to ts, jsx to tsx)
  • Update any components using those to the correct imports
  • [ > Fix any errors generated by the TypeScript compiler. You can run make check-types to display any errors.

We are aiming to be as strict as possible for the time being, but if you run into any issues where the file cannot be successfully migrated without significant change in other libraries, or our tsconfig.json, please feel free to raise them as we are aiming to keep this process smooth and gradual, while enforcing as much as we can.

Some examples of already migrated files can be found here:


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-20404

@tianlangwu
Copy link

I would like to work on this, could you assign it to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants