Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Initial support for typescript and migration of some widgets to tsx #3472

Merged
merged 17 commits into from
Aug 30, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Aug 16, 2019

Summary

As part of the widgets components we going to write the components using
typescript, this PR adds the initial support and some migrations.

For easy the review process the initial support is in the first commit and all
the other commits migrate one widgets folder per each.

Ticket Link

MM-17859

@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Aug 16, 2019
@jespino jespino requested review from lindy65 and a team August 16, 2019 19:18
@jespino jespino added this to the v5.16.0 milestone Aug 16, 2019
@ghost ghost requested review from devinbinnie and gabrieljackson and removed request for a team August 16, 2019 19:19
@jespino jespino added Work in Progress Not yet ready for review and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Aug 16, 2019
@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester and removed Work in Progress Not yet ready for review labels Aug 16, 2019
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jespino - as per your comment on the Jira ticket, no QA really needed here as this is a code change covered by unit tests.

@lindy65 lindy65 removed the 3: QA Review Requires review by a QA tester label Aug 22, 2019
@jespino jespino requested review from reflog and removed request for devinbinnie August 27, 2019 14:04
This was referenced May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants