This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Initial support for typescript and migration of some widgets to tsx #3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespino
added
2: Dev Review
Requires review by a core commiter
3: QA Review
Requires review by a QA tester
labels
Aug 16, 2019
ghost
requested review from
devinbinnie and
gabrieljackson
and removed request for
a team
August 16, 2019 19:19
jespino
added
Work in Progress
Not yet ready for review
and removed
2: Dev Review
Requires review by a core commiter
3: QA Review
Requires review by a QA tester
labels
Aug 16, 2019
jespino
added
2: Dev Review
Requires review by a core commiter
3: QA Review
Requires review by a QA tester
and removed
Work in Progress
Not yet ready for review
labels
Aug 16, 2019
lindy65
approved these changes
Aug 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jespino - as per your comment on the Jira ticket, no QA really needed here as this is a code change covered by unit tests.
This was referenced May 17, 2023
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
4: Reviews Complete
All reviewers have approved the pull request
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
Tests/Not Needed
Does not require new release tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of the widgets components we going to write the components using
typescript, this PR adds the initial support and some migrations.
For easy the review process the initial support is in the first commit and all
the other commits migrate one widgets folder per each.
Ticket Link
MM-17859