Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autolinking doesn't work for TLDs longer than 4 characters #17025

Closed
Gittenburg opened this issue Feb 26, 2021 · 2 comments
Closed

Autolinking doesn't work for TLDs longer than 4 characters #17025

Gittenburg opened this issue Feb 26, 2021 · 2 comments
Labels
Bug Report/Open Bug report/issue

Comments

@Gittenburg
Copy link

Gittenburg commented Feb 26, 2021

Summary

The Markdown autolinking only works for TLDs up to 4 characters.
Even though there are many new TLDs with more than 4 characters, e.g. .africa, .computer, etc.
In fact TLDs can be as long as 63 characters.

Steps to reproduce

With Mattermost v5.32.1, send a message with:

* example.com/page
* example.computer/page

Expected behavior

Both links are autolinked.

Observed behavior (that appears unintentional)

Only the first link is autolinked since the TLD of the second link has more than 4 characters.

Possible fixes

Increase the autolink TLD limit to 63 characters or alternatively check the TLD against a list of all TLDs.

@amyblais amyblais added the Bug Report/Open Bug report/issue label Feb 26, 2021
@amyblais
Copy link
Member

Thanks, opened a ticket: https://mattermost.atlassian.net/browse/MM-33321

@amyblais
Copy link
Member

We are closing some older tickets that have been inactive for a while. If the issue persists on the latest server version, feel free to re-open this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report/Open Bug report/issue
Projects
None yet
Development

No branches or pull requests

2 participants