Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate 'components/invitation_modal/invitation_modal_guest_step' and associated tests to TypeScript #17293

Closed
mattermod opened this issue Mar 26, 2021 · 1 comment · Fixed by mattermost/mattermost-webapp#8590
Assignees
Labels
Area/Technical Debt Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/TypeScript

Comments

@mattermod
Copy link
Contributor

We are starting to migrate the mattermost-webapp over to TypeScript to facilitate better code quality. This Help Wanted issue is to modify components/invitation*modal/invitation_modal_guest*step and associated test files.

Below is a checklist of items you should be doing to migrate:

  • < ] Rename the files to their associated TypeScript extensions (ie. js to ts, jsx to tsx)
  • Update any components using those to the correct imports
  • [ > Fix any errors generated by the TypeScript compiler. You can run make check-types to display any errors.

We are aiming to be as strict as possible for the time being, but if you run into any issues where the file cannot be successfully migrated without significant change in other libraries, or our tsconfig.json, please feel free to raise them as we are aiming to keep this process smooth and gradual, while enforcing as much as we can.

Some examples of already migrated files can be found here:

  1. https://github.com/mattermost/mattermost-webapp/pull/4230

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-34369

@M-ZubairAhmed
Copy link
Member

i will take it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/Technical Debt Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/TypeScript
Projects
None yet
4 participants