MM-14897: Changes to be able to add and remove groups from channels. #10794
Conversation
mkraft
force-pushed
the
MM-15162
branch
3 times, most recently
from
bd93fb8
to
1123490
Compare
mkraft
added
2: Dev Review
| Where("ug.DeleteAt = 0 AND gt.TeamId = ? AND gt.DeleteAt = 0", teamID) | ||
| From(fmt.Sprintf("%s gs", table)). | ||
| LeftJoin("UserGroups ug ON gs.GroupId = ug.Id"). | ||
| Where(fmt.Sprintf("ug.DeleteAt = 0 AND gs.%s = ? AND gs.DeleteAt = 0", idCol), syncableID) |
There was a problem hiding this comment.
I don't like this "query building" approach. I would prefer something more simple like building the entire query two times one for each syncable type. (probably in the query some lines later you can reuse a chunk of the query. Anyway, up to you, feel free to merge it as is, if you think is the best option.
There was a problem hiding this comment.
@jespino I had the same thought as you when it was being written. Perhaps it's tipping the scale towards "too clever" instead of being repetitive. The impetus for doing it this way was that it's such a long query to repeat twice. Is the risk from the repetition worth the risk from the added complexity of interpolating the string? I don't think there's a definitive answer.
mgdelacroix
added
the
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Summary
Changes to be able to add and remove groups from channels.
Pretty similar to some of the changes from #10701 but for Channels.
Ticket Link
https://mattermost.atlassian.net/browse/MM-14897