Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-18262 Converting to structured logging the file app/slackimport.go #12137

Merged
merged 1 commit into from
Sep 16, 2019
Merged

MM-18262 Converting to structured logging the file app/slackimport.go #12137

merged 1 commit into from
Sep 16, 2019

Conversation

niklabh
Copy link
Contributor

@niklabh niklabh commented Sep 10, 2019

Summary

Converting to structured logging the file app/slackimport.go

Ticket Link

https://mattermost.atlassian.net/browse/MM-18262

@hanzei hanzei added the 2: Dev Review Requires review by a developer label Sep 10, 2019
@hanzei hanzei requested a review from a team September 10, 2019 10:27
@ghost ghost requested review from DSchalla and sudheerDev and removed request for a team September 10, 2019 10:27
DSchalla
DSchalla approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@DSchalla DSchalla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@DSchalla DSchalla merged commit 62eeca2 into mattermost:master Sep 16, 2019
@DSchalla DSchalla added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Sep 16, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 16, 2019
@amyblais amyblais added this to the v5.16.0 milestone Sep 16, 2019
@lindy65 lindy65 added Tests/Not Needed New release tests not required and removed 4: Reviews Complete All reviewers have approved the pull request labels Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudheerDev sudheerDev sudheerDev approved these changes

@DSchalla DSchalla DSchalla approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed New release tests not required
Projects
None yet
Milestone
v5.16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@niklabh @sudheerDev @DSchalla @lindy65 @hanzei @amyblais