Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-19137 - Migrate tests from "model/post_test.go" to use testify #13521

Merged
merged 3 commits into from
Jan 13, 2020
Merged

MM-19137 - Migrate tests from "model/post_test.go" to use testify #13521

merged 3 commits into from
Jan 13, 2020

Conversation

0xVolodya
Copy link
Contributor

Summary

Migrate tests from "model/post_test.go" to use testify

Ticket Link

Fixes #12571

@jasonblais jasonblais added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Dec 25, 2019
jespino
jespino approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @nadalfederer! 🎉

lindy65
lindy65 approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nadalfederer 👍

@lindy65 lindy65 added QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process) and removed 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Jan 10, 2020
@jespino
Copy link
Member

jespino commented Jan 10, 2020

/update-branch

@alifarooq0 alifarooq0 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Jan 13, 2020
@alifarooq0 alifarooq0 merged commit ed555fa into mattermost:master Jan 13, 2020
@hanzei hanzei added this to the v5.20.0 milestone Jan 14, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jespino jespino jespino approved these changes

@lindy65 lindy65 lindy65 approved these changes

@alifarooq0 alifarooq0 alifarooq0 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process)
Projects
None yet
Milestone
v5.20.0
Development

Successfully merging this pull request may close these issues.

Migrate tests from "model/post_test.go" to use testify
8 participants
@0xVolodya @jespino @lindy65 @alifarooq0 @jasonblais @hanzei @amyblais @mattermod