Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving filesstore services into shared folder #16940

Merged
merged 8 commits into from
Mar 2, 2021
Merged

Moving filesstore services into shared folder #16940

merged 8 commits into from
Mar 2, 2021

Conversation

jespino
Copy link
Member

@jespino jespino commented Feb 15, 2021 •
edited
Loading

Summary

Moving filesstore services into shared folder

Ticket Link

https://mattermost.atlassian.net/browse/MM-33323

Related PR

enterprise: mattermost/enterprise#925

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 15, 2021
@jespino jespino added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Feb 15, 2021
agnivade
agnivade reviewed Feb 17, 2021
View reviewed changes
app/file.go Outdated Show resolved Hide resolved
@agnivade agnivade requested a review from nronas February 18, 2021 04:09
nronas
nronas approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@nronas nronas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattermod mattermod removed the EETests label Feb 23, 2021
@mgdelacroix mgdelacroix removed the 2: Dev Review Requires review by a developer label Feb 25, 2021
@mattermod mattermod removed the EETests label Feb 26, 2021
@jespino jespino requested a review from lindy65 February 26, 2021 19:03
@jespino
Copy link
Member Author

jespino commented Feb 26, 2021 •
edited
Loading

@jupenur @srkgupta I haven't change the code itself, but because I'm moving it, it is complaining about security problems. I don't know if is needed to review that, or we want to change something before keep going.

@jupenur
Copy link
Member

jupenur commented Feb 27, 2021

Thanks for the ping @jespino. Dismissed the alerts, should be good now.

@lindy65 lindy65 added the Setup Cloud Test Server Setup an on-prem test server label Mar 2, 2021
lindy65
lindy65 approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jespino - looks good to me 👍 Tested as per test steps on Jira ticket and didn't find any issues...

@lindy65 lindy65 removed the 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review label Mar 2, 2021
@lindy65 lindy65 added 4: Reviews Complete All reviewers have approved the pull request and removed Setup Cloud Test Server Setup an on-prem test server labels Mar 2, 2021
@mm-cloud-bot
Copy link

Test server destroyed

@jespino jespino merged commit 78355ae into master Mar 2, 2021
@jespino jespino deleted the moving-filesstore-to-shared branch March 2, 2021 13:37
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nronas nronas nronas approved these changes

@mgdelacroix mgdelacroix mgdelacroix approved these changes

@agnivade agnivade agnivade approved these changes

@lindy65 lindy65 lindy65 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jespino @jupenur @mm-cloud-bot @nronas @mgdelacroix @agnivade @lindy65 @mattermod @amyblais