Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherrypick-50eaec6 #20239

Merged
merged 4 commits into from
May 18, 2022
Merged

cherrypick-50eaec6 #20239

merged 4 commits into from
May 18, 2022

Conversation

larkox
Copy link
Contributor

@larkox larkox commented May 18, 2022 

Fix bug that allow to send test (empty) notifications even if the `SendPushNotifications` config is set to false.

@larkox @mattermod
Respect send push proxy notification configuration on test notificati…
7999c96 
…ons (mattermost#20063)

* Respect send push proxy notification configuration on test notifications

* Unify notifications check

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
@larkox larkox added the 2: Dev Review Requires review by a developer label May 18, 2022
@larkox larkox requested a review from amyblais May 18, 2022 09:38
@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 18, 2022
@amyblais
Copy link
Member

/update-branch

@amyblais
Copy link
Member

There are some failing tests.

@amyblais amyblais added 4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation AutoMerge Used by Mattermod to merge PR automatically and removed 2: Dev Review Requires review by a developer labels May 18, 2022
@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@mattermod
Copy link
Contributor

Trying to auto merge this PR.

@mattermod mattermod merged commit d76abb7 into mattermost:release-6.3 May 18, 2022
@mattermod
Copy link
Contributor

Pull Request successfully merged
SHA: d76abb7

@mattermod mattermod removed the AutoMerge Used by Mattermod to merge PR automatically label May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyblais amyblais amyblais approved these changes

Assignees

@larkox larkox

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@larkox @amyblais @mattermod @mm-cloud-bot