Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always regenerate go.work file #20842

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Always regenerate go.work file #20842

merged 2 commits into from
Aug 17, 2022

Conversation

agnivade
Copy link
Member

@agnivade agnivade commented Aug 17, 2022 •
edited
Loading

We flip the default mode to always regenerate the file,
and expose an option to ignore if it exists.

The way to preserve the old behavior is to use an additional IGNORE_IF_EXISTS flag
like make run-server IGNORE_IF_EXISTS=true.

NONE

@agnivade
Always regenerate go.work file
d0adb1a 
We flip the default mode to always regenerate the file,
and expose an option to ignore if it exists.

```release-note
NONE
```
@agnivade agnivade added the 2: Dev Review Requires review by a developer label Aug 17, 2022
@agnivade agnivade requested a review from wiggin77 August 17, 2022 18:53
@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 17, 2022
@agnivade
Copy link
Member Author

cc @hmhealey @harshilsharma63

lieut-data
lieut-data approved these changes Aug 17, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@agnivade
make flag name clear
32c0a80 
```release-note
NONE
```
@agnivade agnivade added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Aug 17, 2022
@agnivade agnivade merged commit 3498592 into master Aug 17, 2022
@agnivade agnivade deleted the changeGoWork branch August 17, 2022 19:41
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Aug 17, 2022
noxer pushed a commit that referenced this pull request Aug 18, 2022
Squashed commit of the following:
a3ff0ec 
commit 53985ef
Author: Vishal <vish9812@gmail.com>
Date:   Thu Aug 18 14:33:33 2022 +0530

    [MM-45730] Fix Sentry crash: nil deference in model/post_list.go:152 (#20742)

    * Add check to include ID in Order, only if it exists in Posts

    * avoid calling GetPostsBeforePost if lastUnreadPostId is inaccessible

commit a28a967
Author: Tim Scheuermann <noxer@users.noreply.github.com>
Date:   Thu Aug 18 11:01:37 2022 +0200

    MM-45991 Wrap errors (#20785)

commit 8e0d46e
Author: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>
Date:   Wed Aug 17 23:07:04 2022 +0300

    re-assign cluster interface after initializing enterprise interfaces (#20839)

    * re-assign cluster interface after initializing enterprise interfaces

    * add a unit test to check if cluster is triggered

    * remove env overrides

    Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

commit 3498592
Author: Agniva De Sarker <agnivade@yahoo.co.in>
Date:   Thu Aug 18 01:11:18 2022 +0530

    Always regenerate go.work file (#20842)

    We flip the default mode to always regenerate the file,
    and expose an option to ignore if it exists.

    ```release-note
    NONE
    ```

commit a78d91e
Author: Pablo Andrés Vélez Vidal <pablovv2012@gmail.com>
Date:   Wed Aug 17 18:41:11 2022 +0200

    MM-43663 - add missing words to email invite (#20794)

    Co-authored-by: Pablo Velez Vidal <pablo.velez@mattermost.com>

commit df60c20
Author: Doug Lauder <wiggin77@warpmail.net>
Date:   Wed Aug 17 11:21:22 2022 -0400

    add userService to the services provided by channels product (#20840)

commit d9d75b1
Author: Agniva De Sarker <agnivade@yahoo.co.in>
Date:   Wed Aug 17 19:58:52 2022 +0530

    MM-45198: Migrate app/import and api4/import (#20799)

    We migrate them to use logger context.

    https://mattermost.atlassian.net/browse/MM-45198

    ```release-note
    NONE
    ```

commit 5e00295
Author: Agniva De Sarker <agnivade@yahoo.co.in>
Date:   Wed Aug 17 13:36:36 2022 +0530

    MM-38702: Do not fail during importing without attachment (#20800)

    We just log a warning instead of failing completely.

    https://mattermost.atlassian.net/browse/MM-38702

    ```release-note
    NONE
    ```

    Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

commit ad652f1
Author: mattermod <dev-ops@mattermost.com>
Date:   Wed Aug 17 07:08:26 2022 +0000

    Update latest version to 7.2.0

commit 16e0661
Author: Scott Bishel <scott.bishel@mattermost.com>
Date:   Tue Aug 16 12:11:35 2022 -0600

    update built in boards v7.2.0 (#20809)

    Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

commit 09eedaf
Author: Nick Misasi <nick.misasi@mattermost.com>
Date:   Tue Aug 16 11:11:48 2022 -0400

    Add DelinquentSince to Subscription fields (#20655)

    Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

commit 5ea2ca8
Author: Mattermod <mattermod@users.noreply.github.com>
Date:   Mon Aug 15 16:33:58 2022 +0300

    Update minor version to 7.3.0 (#20815)

    Co-authored-by: Mmbot <mmbot@mattermost>

commit efed80a
Author: Akis Maziotis <36594156+phoinixgrr@users.noreply.github.com>
Date:   Sat Aug 13 01:44:32 2022 +0300

    [CLD-3942] Container Image used for e2e testing, migration from Alpine to Debian Linux (#20807)

    * [fix] Dockerfile using Debian instead of Alpine

    We are switching to building docker container for Matermmost-server & enterprise
    from Alpine Linux(unsupported) to Debian(supported)

    This image is used for e2e testing.

    Rationalle:
    Alpine is actually unsupported distro for Mattermost-server. https://docs.mattermost.com/install/software-hardware-requirements.html#mattermost-server-operating-system
    On top of that, Alpine linux uses musl libc vs glibc, which can cause several issues when testing
    Finally We got to a point of being unable to run Alpine based mattermost instances with: `Error relocating ./mattermost: fcntl64: symbol not found`
    Details @ #20735

    Specifically the following changes are introduced:

    - switching to using Debian Buster as being a supported linux flavor for Mattermost
    - pinning the Debian base image with SHA hash
    - defining Shell as bash, and enabling pipefail
    - pinning additional packages installed using apt
    - removing unused cache
    - improving MM_PACKAGE variable checking logic introducing non zero exit code (127) when failing
    - migrating adduser and addgroup command, to debian compatible
    - removing unused chown dirs

    Signed-off-by: Akis Maziotis <akis.maziotis@mattermost.com>

    * [fix] Using bash as a more capable shell

    * [fix] Installing optional packages needed for tests

    These packages are needed to perform succesfull end to end testing.
    Relevant documentation:
    https://docs.mattermost.com/configure/file-storage-configuration-settings.html#enable-document-search-by-content

    Signed-off-by: Akis Maziotis <akis.maziotis@mattermost.com>

commit 6aa57e6
Author: Amy Blais <29708087+amyblais@users.noreply.github.com>
Date:   Fri Aug 12 11:43:49 2022 -0400

    Revert "MM-45272: Fix getPostThread permissions (#20565)" (#20811)

    Automatic Merge

commit 1ef2422
Author: Akis Maziotis <36594156+phoinixgrr@users.noreply.github.com>
Date:   Thu Aug 11 18:16:59 2022 +0300

    [feat] CI essential multi-product architecture changes (#20783)

    * [feat] essential multi-product architecture changes

    This takes care of aligning mattermost-server CircleCI pipeline to the mutlti-product architecture.
    Specifically the following are performed:

    - seperation of mattermost-server and mattermost-webapp clone/setup stages
    - introduction of clone/setup stage for focalboard
    - change to using cimg/base image instaed of  mattermost/mattermost-build-webapp when cloning/setup mattermost-server
    - introduction of `configure-multirepo` stage, in which multi-module workspaces (golang) configuration is being performed for mattermost-server and focalboard
    - introduction of parallel build of focalboard along with mattermost-server
    - reorganisation of step dependencies, to accomodate `configure-multirepo` step

    Ticket: https://mattermost.atlassian.net/browse/CLD-3801
    Signed-off-by: Akis Maziotis <akis.maziotis@mattermost.com>

commit 55b3961
Author: Martin Kraft <martin@upspin.org>
Date:   Thu Aug 11 10:38:52 2022 -0400

    MM-45120: Track team join times. Add API to retrieve new team members since a given time. (#20708)

    * MM-45120: Starts tracking team join time. Adds API to retrieve team members who joined after a given time.

    * MM-45120: Updates json casing to match model.User.

commit 1738bd6
Author: Tim Scheuermann <noxer@users.noreply.github.com>
Date:   Wed Aug 10 11:56:58 2022 +0300

    [MM-45991] Check and return JSON errors (#20735)

commit fdee1df
Author: Jesse Hallam <jesse.hallam@gmail.com>
Date:   Wed Aug 10 01:09:02 2022 -0300

    Pre-package Playbooks v1.31.0 (#20797)

commit f6307be
Author: Christopher Poile <cpoile@gmail.com>
Date:   Tue Aug 9 15:38:00 2022 -0400

    prepackage calls 0.7.1 (#20788)

    Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

commit b4570af
Author: Tim Scheuermann <noxer@users.noreply.github.com>
Date:   Tue Aug 9 14:25:46 2022 +0300

    Replace deprecated ioutil with io and os (#20776)

    * Replace ioutil with io and os

    * Replace ioutil in utils/file.go

    * Minor fix to tests and excluded files

    Co-authored-by: Tim Scheuermann <tim.scheuermann@mattermost.com>
    Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

commit 15b6046
Author: Ashish Bhate <ashish.bhate@mattermost.com>
Date:   Tue Aug 9 16:49:43 2022 +0530

    MM-44922: Flush log buffer before assert (#20795)

    Summary
    Flush log buffer before asserting log text.

    Ticket Link
    https://mattermost.atlassian.net/browse/MM-44922

commit afbbc31
Merge: 97b3ffd 722bd3d
Author: Shivashis Padhi <shivashispadhi@gmail.com>
Date:   Tue Aug 9 11:57:52 2022 +0530

    Merge pull request #20761 from plant99/improve-top-user-reactions

    [MM-45561] Improve user top reactions query

commit 97b3ffd
Author: Agniva De Sarker <agnivade@yahoo.co.in>
Date:   Mon Aug 8 20:02:49 2022 +0530

    MM-43202: Change some 501 response codes to fix SLO violations (#20767)

    There were lots of cases where we were using the code 501
    in an incorrect manner, and since 5xx codes are considered
    as SLO violations, these were flagged by our monitoring incorrectly.

    These were the guidelines to change the codes:
    1. Any case of missing license or config not correctly enabled
    is set as Forbidden. The logic is that the user is correctly
    authenticated with a session, but does not have enough privileges
    to have the higher license, or hasn't changed the config correctly.
    2. Any case of incorrectly formed request is obviously a 400.

    https://mattermost.atlassian.net/browse/MM-43202

    ```release-note
    NONE
    ```

commit 722bd3d
Merge: 3e36894 e715647
Author: Mattermod <mattermod@users.noreply.github.com>
Date:   Thu Aug 4 01:25:36 2022 +0300

    Merge branch 'master' into improve-top-user-reactions

commit 3e36894
Author: Shivashis Padhi <shivashispadhi@gmail.com>
Date:   Wed Aug 3 15:43:09 2022 +0530

    Avoid joining with Posts table while getting top user reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lieut-data lieut-data lieut-data approved these changes

@wiggin77 wiggin77 wiggin77 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agnivade @lieut-data @wiggin77 @amyblais @mm-cloud-bot