Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-52832] : Migrate "components/admin_console/cluster_table.jsx" to Typescript #23471

Merged
merged 5 commits into from
May 26, 2023
Merged

[MM-52832] : Migrate "components/admin_console/cluster_table.jsx" to Typescript #23471

merged 5 commits into from
May 26, 2023

Conversation

amauryplayero
Copy link
Contributor

@amauryplayero amauryplayero commented May 20, 2023 •
edited by jira bot
Loading

Summary
Converted cluster_table to .tsx file, addressed lint errors, and added types.

Ticket Link
MM-23428
https://mattermost.atlassian.net/browse/MM-52832

@mm-cloud-bot
Copy link

@amauryplayero: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@mattermost-build
Copy link
Contributor

Hello @amauryplayero,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@M-ZubairAhmed
Copy link
Member

/release-note-none

@mm-cloud-bot mm-cloud-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed labels May 20, 2023
@M-ZubairAhmed M-ZubairAhmed changed the title [GH-23428] Convert cluster_table.jsx to Typescript [MM-52832] Convert cluster_table.jsx to Typescript May 20, 2023
@M-ZubairAhmed M-ZubairAhmed added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels May 20, 2023
@mattermost-build
Copy link
Contributor

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

sinansonmez
sinansonmez approved these changes May 20, 2023
View reviewed changes
Copy link
Contributor

@sinansonmez sinansonmez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@M-ZubairAhmed M-ZubairAhmed changed the title [MM-52832] Convert cluster_table.jsx to Typescript [MM-52832] : Migrate "components/admin_console/cluster_table.jsx" to Typescript May 22, 2023
@amauryplayero
Copy link
Contributor Author

@M-ZubairAhmed Just updated the PR with requested changes :)

@M-ZubairAhmed
Copy link
Member

/update-branch

@M-ZubairAhmed M-ZubairAhmed removed the 2: Dev Review Requires review by a developer label May 22, 2023
@yasserfaraazkhan
Copy link
Contributor

/e2e-test

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

yasserfaraazkhan
yasserfaraazkhan approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@M-ZubairAhmed ,
tested it separately. verified the failing tests manually.

this should be good to merge.
#23515

@M-ZubairAhmed M-ZubairAhmed added 4: Reviews Complete All reviewers have approved the pull request EETests and removed 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels May 26, 2023
@M-ZubairAhmed M-ZubairAhmed merged commit abcfa8c into mattermost:master May 26, 2023
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 26, 2023
sbishel pushed a commit to sbishel/mattermost that referenced this pull request Aug 15, 2023
@amauryplayero @sbishel
[MM-52832] : Migrate "components/admin_console/cluster_table.jsx" to …
fa848b7 
…Typescript (mattermost#23471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasserfaraazkhan yasserfaraazkhan yasserfaraazkhan approved these changes

@M-ZubairAhmed M-ZubairAhmed M-ZubairAhmed approved these changes

@sinansonmez sinansonmez sinansonmez approved these changes

@affkjuhyt affkjuhyt affkjuhyt approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Contributor Docs/Not Needed Does not require documentation release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@amauryplayero @mm-cloud-bot @mattermost-build @M-ZubairAhmed @yasserfaraazkhan @sinansonmez @affkjuhyt @amyblais