Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-9631: Add GetPostsBefore() to plugin API #9651

Merged
merged 1 commit into from
Oct 15, 2018
Merged

GH-9631: Add GetPostsBefore() to plugin API #9651

merged 1 commit into from
Oct 15, 2018

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Oct 13, 2018 •
edited
Loading

Summary

This PR adds a GetPostsBefore(channelId, postId string, page, perPage int) method to plugin API.

Ticket Link

Fixes #9631

@hanzei hanzei changed the title GH-9630: Add GetPostsAfter() to plugin API GH-9630: Add GetPostsBefore() to plugin API Oct 13, 2018
@hanzei hanzei changed the title GH-9630: Add GetPostsBefore() to plugin API GH-9631: Add GetPostsBefore() to plugin API Oct 13, 2018
@jasonblais jasonblais added 2: Dev Review Requires review by a developer Hacktoberfest labels Oct 13, 2018
cpanato
cpanato approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks so much for this PR

@cpanato
Copy link
Contributor

cpanato commented Oct 15, 2018

@hanzei can you please rebase this PR, then we can merge it. thanks again

@hanzei
Copy link
Contributor Author

hanzei commented Oct 15, 2018

@cpanato Done

@cpanato cpanato added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Oct 15, 2018
@cpanato cpanato merged commit 71b7b9f into mattermost:master Oct 15, 2018
@hanzei hanzei deleted the GH-9631 branch October 15, 2018 17:19
@lindalumitchell lindalumitchell added the Tests/Not Needed New release tests not required label Nov 7, 2018
@amyblais amyblais added Docs/Needed Requires documentation Changelog/Done Required changelog entry has been written labels Nov 16, 2018
@jasonblais jasonblais added Docs/Done Required documentation has been written and removed Docs/Needed Requires documentation labels Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwilander jwilander jwilander approved these changes

@cpanato cpanato cpanato approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Done Required documentation has been written Hacktoberfest Tests/Not Needed New release tests not required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hanzei @cpanato @jwilander @jasonblais @lindalumitchell @amyblais