This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-34366: Migrate 'components/post_view/post_list_virtualized' and associated tests to TypeScript #10426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @sinansonmez, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
mattermod
requested review from
a team and
hmhealey
and removed request for
a team
mattermod
added
2: Dev Review
hmhealey
suggested changes
Jun 2, 2022
mickmister
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Thanks @sinansonmez! LGTM 👍
I agree with Harrison's comments
hmhealey
approved these changes
Jun 8, 2022
hmhealey
added
Setup Cloud Test Server
|
/e2e-tests |
|
Successfully triggered e2e testing! |
|
/update-branch |
jgilliam17
added
3: QA Review
|
Successfully triggered e2e testing! |
jgilliam17
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
Thanks @sinansonmez
Tested, looks good to merge.
- Verified post list, new message line and toast, date separator, loading indicator etc. - working as before.
- E2E report looks good, no PR related failures.
jgilliam17
added
4: Reviews Complete
|
Test server destroyed |
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates 'components/post_view/post_list_virtualized' and associated tests to TypeScript
Ticket Link
Fixes mattermost/mattermost#17289
JIRA: https://mattermost.atlassian.net/browse/MM-34366
Release Note