This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Remove old post components code and update tests #11397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-ZubairAhmed
approved these changes
Nov 12, 2022
added 6 commits
December 6, 2022 20:35
|
/e2e-test |
|
Successfully triggered E2E testing! |
|
/update-branch |
|
/e2e-test |
|
Successfully triggered E2E testing! |
|
/e2e-test |
|
Successfully triggered E2E testing! |
|
I saw 95% pass and pulled latest fixes from master, |
nevyangelova
force-pushed
the
remove-unused-post-code
branch
from
7f98c00
to
3014fbd
Compare
|
/e2e-test |
|
Successfully triggered E2E testing! |
nevyangelova
pushed a commit
that referenced
this pull request
Jan 30, 2023
* Add new post to all places * Linter * fix reply bug * pass missing props for current user id * Fix props passign * Fix linter * UI bugs * Fix UI bugs pt.1 * UI error * Fix lint * fix jump highlight * PR comments * remove console * PR comments - DEV * QA comments * PR comments by Harrison and Zubair * fix checks * Add post reaction location * Initial E2e fixes for post components (#11693) * Initial fix of e2e test related to the post component update * Fix linter * add correct test ids * Add extra ids * final ids` * Adding post ids to the post body * Fix post editing in RHS and CENTER * Fix rhs true for message with additional content * remove redundant check for RHS + redundant function * replace hardcoded isRHS * Update second function replacing the post ID * Correct id for div of post__body * Fix data-testid position for search results * isRHS should be true for search results too * Hardcoded value for location * post reaction type * Fix null user profile in consecutive post * fix linting error * update check for search results item * Bulk tests * Types * bulk number 2 * a11y errors * Bulk fix * show menu with emoji picker Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MacBook-Pro.local> Co-authored-by: Pantelis Vratsalis <pvratsalis@gmail.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com> * Add aknowledgements and priority * Adjust post acknowledgements * QA comments * Fix shortcut for emoji picker * QA bugs * Add new bot badge * Fix test * fix forwarding spec * all e2e fixes * fix QA bugs * final fix * Remove old post components code and update tests (#11397) * Remove old post components code and update tests * fix types * fix test * remove search result item * fix rebase errors * Rebase errors Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MacBook-Pro.local> * Fixes after merge * Fix scrolls spec * FIx remaining tests and bugs * fix saved posts --------- Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MacBook-Pro.local> Co-authored-by: Pantelis Vratsalis <pvratsalis@gmail.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com> Co-authored-by: Mattermost Build <build@mattermost.com>
amyblais
added
Changelog/Done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of https://mattermost.atlassian.net/browse/MM-43162 is to remove unused old components code, adjust styles, fix unit tests, e2e tests. This PR will handle this
[x] - Removed old post components
[x] - Updated unit tests and snapshots
Ticket Link
https://mattermost.atlassian.net/browse/MM-43162
Related Pull Requests
#11127
Release Note