Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-50306] - Clickable username in RHS #12141

Merged
merged 3 commits into from
Feb 6, 2023
Merged

[MM-50306] - Clickable username in RHS #12141

merged 3 commits into from
Feb 6, 2023

Conversation

coltoneshaw
Copy link
Member

Summary

Made the username clickable within the channel RHS

Ticket Link

https://mattermost.atlassian.net/browse/MM-50306

Screenshots

Before
Before.mov
After
After.mov

Release Note

Channel RHS usernames are clickable

@JulienTant JulienTant added Setup Cloud Test Server Setup a test server using Mattermost Cloud 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Feb 3, 2023
@mattermost-build
Copy link
Contributor

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

JulienTant
JulienTant suggested changes Feb 3, 2023
View reviewed changes
Copy link
Member

@JulienTant JulienTant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coltoneshaw! Solid improvement! just left one change request because we do not use inline style, but the feature works great!

components/channel_members_rhs/member.tsx Outdated Show resolved Hide resolved
@stevemudie
Copy link
Contributor

/e2e-test

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@stevemudie
Copy link
Contributor

Looks good @coltoneshaw! Once the E2E tests run (and presumably pass) I'll give it the green light.

@coltoneshaw
Copy link
Member Author

@stevemudie i see some fails that don't seem related to the changes I made, but I'm admittedly a noob for our E2E tests.

@stevemudie stevemudie added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Feb 3, 2023
@M-ZubairAhmed M-ZubairAhmed added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter QA Review Done labels Feb 5, 2023
@AshishDhama
Copy link
Contributor

/update-branch

@coltoneshaw coltoneshaw force-pushed the MM-50306-clickable-username-channel-rhs branch from 5651d09 to 0f76356 Compare February 6, 2023 16:39
@JulienTant JulienTant added the AutoMerge used by Mattermod to merge PR automatically label Feb 6, 2023
@mattermost-build
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@mattermost-build
Copy link
Contributor

Trying to auto merge this PR.

@mattermost-build mattermost-build merged commit 7f5e914 into mattermost:master Feb 6, 2023
@mattermost-build
Copy link
Contributor

Pull Request successfully merged
SHA: 7f5e914

@mattermost-build mattermost-build removed AutoMerge used by Mattermod to merge PR automatically Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Feb 6, 2023
@mm-cloud-bot
Copy link

Test server destroyed

1 similar comment
@mm-cloud-bot
Copy link

Test server destroyed

@coltoneshaw coltoneshaw deleted the MM-50306-clickable-username-channel-rhs branch February 6, 2023 17:10
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JulienTant JulienTant JulienTant approved these changes

@stevemudie stevemudie stevemudie approved these changes

@AshishDhama AshishDhama AshishDhama approved these changes

@M-ZubairAhmed M-ZubairAhmed M-ZubairAhmed approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation release-note
Projects
None yet
Milestone
No milestone
8 participants
@coltoneshaw @mattermost-build @stevemudie @AshishDhama @mm-cloud-bot @JulienTant @M-ZubairAhmed @amyblais