Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-50308 status in more places #12264

Merged
merged 10 commits into from Mar 7, 2023
Merged

Conversation

coltoneshaw
Copy link
Member

Duplicate of #12147 to fix the s3 bucket issue on forks.

Summary

Added the custom user status in the RHS user list, fixed the style in the team members list, and added it to the Sys Console > Users list for fun.

Ticket Link

https://mattermost.atlassian.net/browse/MM-50308

Screenshots

before after
Screenshot 2023-02-03 at 2 18 06 PM Screenshot 2023-02-03 at 2 15 42 PM
Screenshot 2023-02-03 at 2 17 52 PM Screenshot 2023-02-03 at 2 15 33 PM
Screenshot 2023-02-03 at 2 17 58 PM Screenshot 2023-02-03 at 2 15 25 PM

Release Note

Show custom user status in channels RHS and system console.

@coltoneshaw coltoneshaw added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud 1: UX Review Requires review by a UX Designer labels Feb 24, 2023
@mattermost-build
Copy link
Contributor

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

@coltoneshaw
Copy link
Member Author

@matthewbirtch / @BenCookie95 / @kostaspt - I saw they mentioned no ETA on fixing this for forks so I just moved it over here. Same PR as #12147. Just to unblock it. I'll merge the cloud server fix in just a moment

@github-actions
Copy link

github-actions bot commented Feb 24, 2023

Test Results

       1 files     815 suites   14m 3s ⏱️
6 933 tests 6 932 ✔️ 1 💤 0
7 109 runs  7 108 ✔️ 1 💤 0

Results for commit f31b27d.

♻️ This comment has been updated with latest results.

@coltoneshaw coltoneshaw changed the title Mm 50308 status in more places MM-50308 status in more places Feb 24, 2023
Copy link
Contributor

@matthewbirtch matthewbirtch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenCookie95 BenCookie95 removed 2: Dev Review Requires review by a core commiter 1: UX Review Requires review by a UX Designer labels Mar 1, 2023
Copy link
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coltoneshaw custom status shows correctly, except in a few places.

image

image

image

image

Custom Status is not getting shown in the thread

image

Custom Status is not getting shown in Saved Posts

image

Custom Status is not getting shown in Recent mentions

image

Unable to type in the Search emojis field

image

UserA is not able to see the custom status of UserB in the channel and DM

image

@coltoneshaw
Copy link
Member Author

@furqanmlk - the unable to type thing is a bug that was reported and fixed https://mattermost.atlassian.net/browse/MM-5079

The other three (mentions, DM sidebar, and threads) seem to work in community just fine. Let me see if updating this PR fixes it

@coltoneshaw
Copy link
Member Author

@furqanmlk - I updated the branch and just retried everything. It's all resolved that you listed. Let me know if you see anything else!

Saved Posts

Screenshot 2023-03-06 at 3 18 50 PM

DM (note sys admin doesn't have a status set)

Screenshot 2023-03-06 at 3 18 12 PM

Recent Mentions

Screenshot 2023-03-06 at 3 20 18 PM

@furqanmlk
Copy link
Contributor

/e2e-test

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@BenCookie95 BenCookie95 merged commit 2a51459 into master Mar 7, 2023
@BenCookie95 BenCookie95 deleted the mm-50308-status-in-more-places branch March 7, 2023 20:30
@mattermost-build mattermost-build removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Mar 7, 2023
@mm-cloud-bot
Copy link

Test server destroyed

1 similar comment
@mm-cloud-bot
Copy link

Test server destroyed

@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3: QA Review Requires review by a QA tester Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation release-note
Projects
None yet
8 participants