Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

PLT-6577 scroll sidebar on click "more unreads" #2

Merged
merged 1 commit into from
Sep 11, 2017

Conversation

jespino
Copy link
Member

@jespino jespino commented Sep 7, 2017

@jwilander jwilander added the 2: Dev Review Requires review by a core commiter label Sep 7, 2017
@jwilander jwilander requested review from jwilander, enahum and hmhealey and removed request for enahum September 7, 2017 12:12
@jwilander jwilander added this to the v4.3.0 milestone Sep 7, 2017
Copy link
Member

@hmhealey hmhealey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing that to pass in a click handler. Just a couple small things that could be simplified

components/sidebar.jsx Outdated Show resolved Hide resolved
components/sidebar.jsx Outdated Show resolved Hide resolved
components/unread_channel_indicator.jsx Outdated Show resolved Hide resolved
@jespino
Copy link
Member Author

jespino commented Sep 7, 2017

Fixed

Copy link
Member

@hmhealey hmhealey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@jwilander jwilander added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Sep 11, 2017
@jwilander jwilander merged commit 33ca826 into mattermost:master Sep 11, 2017
@lindalumitchell lindalumitchell added the Tests/Done Release tests have been written label Oct 2, 2017
@jasonblais jasonblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Oct 2, 2017
lieut-data added a commit that referenced this pull request Feb 16, 2018
* MM-8589: expunge global mm_(config|license) from integration components

This also reorganizes `components/integrations/components` as just
`components/integrations`

* MM-8589: expunge global mm_config from post_view components

* MM-8589: expunge global mm_config from admin_console components

* fix missing key on admin_console RadioSetting component

* MM-8589: expunge global mm_license from admin_console components

This commit takes a different tack than others on account of the heavy
use of the license object throughout the pages and the non-connectedness
of most components. Instead of denormalizing the individual properties
of the license per components, the `license` object itself is passed
down in most cases. Unfortunately, this means the `=== 'true'` checks
remain littered throughout, but those will be removed at the same time
we cut over all the connectors.

* MM-8589: expunge unnecessary ownProps

* MM-8589: use the get(Config|License) selector
lieut-data added a commit that referenced this pull request Feb 28, 2018
) (#863)

* MM-9635: expunge global mm_config from switch channel provider

* MM-9635: expunge global mm_config from the root components, except for globally exporting it

* MM-9635: fix incorrectly required customDescriptionText in email signup component

* MM-9635: expunge global mm_config from various action files

* MM-9635: deduplicate config/license code loading

This preserves semantics, except for allowing a `loadCurrentLocale` even if config hasn't
loaded, since this is safe.
@miguelespinoza miguelespinoza mentioned this pull request Aug 23, 2018
6 tasks
devinbinnie added a commit that referenced this pull request Mar 16, 2020
devinbinnie added a commit that referenced this pull request Mar 18, 2020
* [MM-20881] Moved out old sidebar and added setting to activate new one (#4553)

* Redux update

* Update redux commit

* Redux merge

* Base channel sidebar architecture (#4706)

Automatic Merge

* [MM-21911] Moved favicon and titlebar update to its own component (#4811)

* [MM-21911] Moved favicon and titlebar update to its own component

* Moved favicon/title tests to their own file

* PR feedback

* [MM-21907][MM-21908] Unread Handling and Scrolling (#4799)

* WIP

* Barely working sidebar

* Temp fix so you can use the sidebar better

* Lint and type fixes

* Unread badge and bolding class added

* Split up sidebar channel types into different components

* Lint/type fixes

* WIP

* PR feedback

* Lint fix

* Unread indicators and scrolling!

* Auto scrolling when changing teams/when channel is in view

* Lint and type fixes

* Another type fix

* Removing unnecessary styling

* PR feedback

* package fix

* Reverted to regular scrollbars

* Whoops, left my dumb test styling in :P

* PR feedback

* aaa

* [MM-21909] Keyboard shortcuts and a11y-controller classes (#4821)

* WIP

* Barely working sidebar

* Temp fix so you can use the sidebar better

* Lint and type fixes

* Unread badge and bolding class added

* Split up sidebar channel types into different components

* Lint/type fixes

* WIP

* PR feedback

* Lint fix

* Unread indicators and scrolling!

* Auto scrolling when changing teams/when channel is in view

* Lint and type fixes

* Another type fix

* Removing unnecessary styling

* PR feedback

* package fix

* Added a11y classes to new sidebar

* Keyboard shortcuts

* Reverted to regular scrollbars

* Whoops, left my dumb test styling in :P

* PR feedback

* Removed isSwitchingChannel

* aaa

* Revert redux commit until tests are fixed

* [MM-22290] Collapsible Category Logic (#4873)

* Barebone collapsing of categories (no saving)

* Take into account unreads and if the channel is the current visible channel

* Reactifying and cleaning up a couple small things

* More cleanup

* Clarity

* Added new style sheet for new sidebar, and the animation for collapsing categories

* Lint/type fixes and accessibility

* Moved a11y section to just the title, for better reading and navigation

* Removing code that won't be used

* Merge'd

* Category name is repeated

* PR feedback

* Removing unnecessary code

* [MM-21910] Modal Handling for new Sidebar (#4847)

* WIP

* Barely working sidebar

* Temp fix so you can use the sidebar better

* Lint and type fixes

* Unread badge and bolding class added

* Split up sidebar channel types into different components

* Lint/type fixes

* WIP

* PR feedback

* Lint fix

* Unread indicators and scrolling!

* Auto scrolling when changing teams/when channel is in view

* Lint and type fixes

* Another type fix

* Removing unnecessary styling

* PR feedback

* package fix

* Added a11y classes to new sidebar

* Keyboard shortcuts

* Reverted to regular scrollbars

* Whoops, left my dumb test styling in :P

* Moved modals over to sidebar

* PR feedback

* Removed isSwitchingChannel

* aaa

* Modals functional

* PR feedback

* Merge'd

* MM-22114 Add view state for collapsed categories and unread filter (#4914)

* [MM-22291] Additional functionality from old sidebar (#4860)

* [MM-22291] Additional functionality from old sidebar

* PR feedback

* PR feedback

* Lank bline

* Lint again

* PR feedback

* Merge'd

* PR feedback

* MM-21584 Replace removeItem call with setItem (#5003)

* Update redux commit

* Merging of CSS styles into new sidebar code (#4998)

* [MM-22291] Additional functionality from old sidebar

* PR feedback

* PR feedback

* Lank bline

* Lint again

* PR feedback

* Merge'd

* Actual functioning sidebar!

* Using react-custom-scrollbars again and fixed a few styling issues

* PR feedback

* Lint fixes

Co-authored-by: mattermod <mattermod@users.noreply.github.com>

* [MM-22478] Unread Filtering and Create New Channel Menu (#5005)

* [MM-22291] Additional functionality from old sidebar

* PR feedback

* PR feedback

* Lank bline

* Lint again

* PR feedback

* Merge'd

* Actual functioning sidebar!

* Using react-custom-scrollbars again and fixed a few styling issues

* PR feedback

* Added base structure

* Unread filter and add channel dropdown design and some functionality

* Unread filtering and collapsible category logic hookup to redux

* Lint fixes

* Added translations

* Disable collapse when unread filter is on

* Merge'd

* PR feedback

* And more

Co-authored-by: mattermod <mattermod@users.noreply.github.com>

* CSS fix for single team instances

* PR feedback and some more missing redux hookups

* Mobile/Desktop Sidebar View + Restored Team Sidebar and Header (#5016)

* [MM-22291] Additional functionality from old sidebar

* PR feedback

* PR feedback

* Lank bline

* Lint again

* PR feedback

* Merge'd

* Actual functioning sidebar!

* Using react-custom-scrollbars again and fixed a few styling issues

* PR feedback

* Lint fixes

* WIP

* Added back original team sidebar and sidebar header for Phase 1

* Mobile bar fits, still styling issues

* Style and lint fixes to make the sidebar work properly

* Desktop and other mobile fixes

* Merge'd

Co-authored-by: mattermod <mattermod@users.noreply.github.com>

* Fixed labels to match spec

* Snapshot update

* Channel Switcher + History Button Style (#5023)

* [MM-22291] Additional functionality from old sidebar

* PR feedback

* PR feedback

* Lank bline

* Lint again

* PR feedback

* Merge'd

* Actual functioning sidebar!

* Using react-custom-scrollbars again and fixed a few styling issues

* PR feedback

* Lint fixes

* Added channel switcher modal button and back/forward buttons

* Lint fixes and formatting

* Styled arrows and buttons, and mock back/forward

* Unmocking for Phase 1

* Removed unnecessary ms-filter

Co-authored-by: mattermod <mattermod@users.noreply.github.com>

* Fixed so that the swap between old and new sidebars is instant, mobile view fixes

* Type fix

* Lint fix

* PR feedback for Eric/Harrison

* A bunch of alignment changes

* Another design fix

* [MM-23056] Analytics for new and old sidebar

* More alignment fixes

* Fixed letter cutoff issue and an alignment issue

* [MM-22834] Hide unused Account Settings options when the new sidebar is enabled

* Even more more alignment fixes, a test fix and some scrolling fixes

* Additional alignment and style fixes

* Alignment fixes for the history arrows

* Fixed a test and a couple small issues

* Added missing tooltips

* Fix for the team switching crashing issue

* Lint fix

* A lot of a11y fixes, still need more

* Lint and test fixes

* Added some missing aria-labels

* Fix crash issue #2

* Removed autoclose redirect since it can't fire

* Removed more dead code

* Redux update

* PR feedback

* Fixed a couple more small issues

* Fixed a redux issue

* More redux fixes and a bug fix

* Fixed a test

* Lint error

Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com>
Co-authored-by: mattermod <mattermod@users.noreply.github.com>
sowmiyamuthuraman pushed a commit to sowmiyamuthuraman/mattermost-webapp that referenced this pull request Apr 10, 2020
* [MM-20881] Moved out old sidebar and added setting to activate new one (mattermost#4553)

* Redux update

* Update redux commit

* Redux merge

* Base channel sidebar architecture (mattermost#4706)

Automatic Merge

* [MM-21911] Moved favicon and titlebar update to its own component (mattermost#4811)

* [MM-21911] Moved favicon and titlebar update to its own component

* Moved favicon/title tests to their own file

* PR feedback

* [MM-21907][MM-21908] Unread Handling and Scrolling (mattermost#4799)

* WIP

* Barely working sidebar

* Temp fix so you can use the sidebar better

* Lint and type fixes

* Unread badge and bolding class added

* Split up sidebar channel types into different components

* Lint/type fixes

* WIP

* PR feedback

* Lint fix

* Unread indicators and scrolling!

* Auto scrolling when changing teams/when channel is in view

* Lint and type fixes

* Another type fix

* Removing unnecessary styling

* PR feedback

* package fix

* Reverted to regular scrollbars

* Whoops, left my dumb test styling in :P

* PR feedback

* aaa

* [MM-21909] Keyboard shortcuts and a11y-controller classes (mattermost#4821)

* WIP

* Barely working sidebar

* Temp fix so you can use the sidebar better

* Lint and type fixes

* Unread badge and bolding class added

* Split up sidebar channel types into different components

* Lint/type fixes

* WIP

* PR feedback

* Lint fix

* Unread indicators and scrolling!

* Auto scrolling when changing teams/when channel is in view

* Lint and type fixes

* Another type fix

* Removing unnecessary styling

* PR feedback

* package fix

* Added a11y classes to new sidebar

* Keyboard shortcuts

* Reverted to regular scrollbars

* Whoops, left my dumb test styling in :P

* PR feedback

* Removed isSwitchingChannel

* aaa

* Revert redux commit until tests are fixed

* [MM-22290] Collapsible Category Logic (mattermost#4873)

* Barebone collapsing of categories (no saving)

* Take into account unreads and if the channel is the current visible channel

* Reactifying and cleaning up a couple small things

* More cleanup

* Clarity

* Added new style sheet for new sidebar, and the animation for collapsing categories

* Lint/type fixes and accessibility

* Moved a11y section to just the title, for better reading and navigation

* Removing code that won't be used

* Merge'd

* Category name is repeated

* PR feedback

* Removing unnecessary code

* [MM-21910] Modal Handling for new Sidebar (mattermost#4847)

* WIP

* Barely working sidebar

* Temp fix so you can use the sidebar better

* Lint and type fixes

* Unread badge and bolding class added

* Split up sidebar channel types into different components

* Lint/type fixes

* WIP

* PR feedback

* Lint fix

* Unread indicators and scrolling!

* Auto scrolling when changing teams/when channel is in view

* Lint and type fixes

* Another type fix

* Removing unnecessary styling

* PR feedback

* package fix

* Added a11y classes to new sidebar

* Keyboard shortcuts

* Reverted to regular scrollbars

* Whoops, left my dumb test styling in :P

* Moved modals over to sidebar

* PR feedback

* Removed isSwitchingChannel

* aaa

* Modals functional

* PR feedback

* Merge'd

* MM-22114 Add view state for collapsed categories and unread filter (mattermost#4914)

* [MM-22291] Additional functionality from old sidebar (mattermost#4860)

* [MM-22291] Additional functionality from old sidebar

* PR feedback

* PR feedback

* Lank bline

* Lint again

* PR feedback

* Merge'd

* PR feedback

* MM-21584 Replace removeItem call with setItem (mattermost#5003)

* Update redux commit

* Merging of CSS styles into new sidebar code (mattermost#4998)

* [MM-22291] Additional functionality from old sidebar

* PR feedback

* PR feedback

* Lank bline

* Lint again

* PR feedback

* Merge'd

* Actual functioning sidebar!

* Using react-custom-scrollbars again and fixed a few styling issues

* PR feedback

* Lint fixes

Co-authored-by: mattermod <mattermod@users.noreply.github.com>

* [MM-22478] Unread Filtering and Create New Channel Menu (mattermost#5005)

* [MM-22291] Additional functionality from old sidebar

* PR feedback

* PR feedback

* Lank bline

* Lint again

* PR feedback

* Merge'd

* Actual functioning sidebar!

* Using react-custom-scrollbars again and fixed a few styling issues

* PR feedback

* Added base structure

* Unread filter and add channel dropdown design and some functionality

* Unread filtering and collapsible category logic hookup to redux

* Lint fixes

* Added translations

* Disable collapse when unread filter is on

* Merge'd

* PR feedback

* And more

Co-authored-by: mattermod <mattermod@users.noreply.github.com>

* CSS fix for single team instances

* PR feedback and some more missing redux hookups

* Mobile/Desktop Sidebar View + Restored Team Sidebar and Header (mattermost#5016)

* [MM-22291] Additional functionality from old sidebar

* PR feedback

* PR feedback

* Lank bline

* Lint again

* PR feedback

* Merge'd

* Actual functioning sidebar!

* Using react-custom-scrollbars again and fixed a few styling issues

* PR feedback

* Lint fixes

* WIP

* Added back original team sidebar and sidebar header for Phase 1

* Mobile bar fits, still styling issues

* Style and lint fixes to make the sidebar work properly

* Desktop and other mobile fixes

* Merge'd

Co-authored-by: mattermod <mattermod@users.noreply.github.com>

* Fixed labels to match spec

* Snapshot update

* Channel Switcher + History Button Style (mattermost#5023)

* [MM-22291] Additional functionality from old sidebar

* PR feedback

* PR feedback

* Lank bline

* Lint again

* PR feedback

* Merge'd

* Actual functioning sidebar!

* Using react-custom-scrollbars again and fixed a few styling issues

* PR feedback

* Lint fixes

* Added channel switcher modal button and back/forward buttons

* Lint fixes and formatting

* Styled arrows and buttons, and mock back/forward

* Unmocking for Phase 1

* Removed unnecessary ms-filter

Co-authored-by: mattermod <mattermod@users.noreply.github.com>

* Fixed so that the swap between old and new sidebars is instant, mobile view fixes

* Type fix

* Lint fix

* PR feedback for Eric/Harrison

* A bunch of alignment changes

* Another design fix

* [MM-23056] Analytics for new and old sidebar

* More alignment fixes

* Fixed letter cutoff issue and an alignment issue

* [MM-22834] Hide unused Account Settings options when the new sidebar is enabled

* Even more more alignment fixes, a test fix and some scrolling fixes

* Additional alignment and style fixes

* Alignment fixes for the history arrows

* Fixed a test and a couple small issues

* Added missing tooltips

* Fix for the team switching crashing issue

* Lint fix

* A lot of a11y fixes, still need more

* Lint and test fixes

* Added some missing aria-labels

* Fix crash issue mattermost#2

* Removed autoclose redirect since it can't fire

* Removed more dead code

* Redux update

* PR feedback

* Fixed a couple more small issues

* Fixed a redux issue

* More redux fixes and a bug fix

* Fixed a test

* Lint error

Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com>
Co-authored-by: mattermod <mattermod@users.noreply.github.com>
Zlash65 added a commit to kredily/mattermost-webapp that referenced this pull request Apr 28, 2020
hmhealey added a commit that referenced this pull request Aug 28, 2020
PLT-5898 preserve device token after logout (master)
catalintomai added a commit to catalintomai/mattermost-webapp that referenced this pull request Sep 16, 2020
furqanmlk pushed a commit that referenced this pull request Dec 8, 2020
hmhealey added a commit that referenced this pull request Mar 17, 2021
PLT-5898 preserve device token after logout (master)
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
* Added actions and API integration for Custom statuses (#2)

* Added actions and API integration for Custom statuses

* Modified the custom status APIs

* Added EnableCustomUserStatuses in config

* Added setCustomStatusInitializationState action to the preferences (#4)

* Added setCustomStatusInitializationState action to the preferences

* Added constant for recent custom statuses

* Modified setCustomStatusInitialisationState action to take object instead of string

Co-authored-by: Manoj <77336594+manojosh@users.noreply.github.com>
Co-authored-by: Manoj <manoj@brightscout.com>
TheLaw1337 added a commit to TheLaw1337/mattermost-webapp that referenced this pull request Oct 9, 2021
josephbaylon pushed a commit that referenced this pull request Oct 14, 2021
* Adding test spec for skin tone emojis

* Adding step #2 (code linted)

* Apply comments suggestions from code review

Co-authored-by: Joseph Baylon <joseph.baylon@mattermost.com>

Co-authored-by: Joseph Baylon <joseph.baylon@mattermost.com>
mickmister added a commit that referenced this pull request Mar 22, 2022
* WIP - need to restore Binding.Call

* Address missing pieces

* Re-add the submit field on calls and improve tests

* Update i18n

* apps API changes fixup

* apps API changes fixup #2: form/modal

* Address feedback

* Address feedback

* Fix lint

* Fix missing error->text change

* fix openAppsModal references

* lint, types, and i18n

* lint

* missing method

* update snapshots

* Fixed handleBindingClick, was double-wrapping .data

* fixed embedded button binding

* various fixes

* fix lookups for command parser

* sync app command parser

* types

* fix tests

* change control flow for cleaning bindings

* re-expand bindings when post is updated

* getDerivedStateFromProps to avoid lint rule

* avoid `this` usage in static function

* fix other spot with same issue

Co-authored-by: Lev Brouk <lev@mattermost.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
mattermost-build pushed a commit to mattermost-build/mattermost-webapp that referenced this pull request Mar 23, 2022
* WIP - need to restore Binding.Call

* Address missing pieces

* Re-add the submit field on calls and improve tests

* Update i18n

* apps API changes fixup

* apps API changes fixup mattermost#2: form/modal

* Address feedback

* Address feedback

* Fix lint

* Fix missing error->text change

* fix openAppsModal references

* lint, types, and i18n

* lint

* missing method

* update snapshots

* Fixed handleBindingClick, was double-wrapping .data

* fixed embedded button binding

* various fixes

* fix lookups for command parser

* sync app command parser

* types

* fix tests

* change control flow for cleaning bindings

* re-expand bindings when post is updated

* getDerivedStateFromProps to avoid lint rule

* avoid `this` usage in static function

* fix other spot with same issue

Co-authored-by: Lev Brouk <lev@mattermost.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
(cherry picked from commit 25f31f5)
amyblais pushed a commit that referenced this pull request Mar 23, 2022
* WIP - need to restore Binding.Call

* Address missing pieces

* Re-add the submit field on calls and improve tests

* Update i18n

* apps API changes fixup

* apps API changes fixup #2: form/modal

* Address feedback

* Address feedback

* Fix lint

* Fix missing error->text change

* fix openAppsModal references

* lint, types, and i18n

* lint

* missing method

* update snapshots

* Fixed handleBindingClick, was double-wrapping .data

* fixed embedded button binding

* various fixes

* fix lookups for command parser

* sync app command parser

* types

* fix tests

* change control flow for cleaning bindings

* re-expand bindings when post is updated

* getDerivedStateFromProps to avoid lint rule

* avoid `this` usage in static function

* fix other spot with same issue

Co-authored-by: Lev Brouk <lev@mattermost.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
(cherry picked from commit 25f31f5)

Co-authored-by: Daniel Espino García <larkox@gmail.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Willyfrog pushed a commit to Willyfrog/mattermost-webapp that referenced this pull request May 6, 2022
* WIP - need to restore Binding.Call

* Address missing pieces

* Re-add the submit field on calls and improve tests

* Update i18n

* apps API changes fixup

* apps API changes fixup mattermost#2: form/modal

* Address feedback

* Address feedback

* Fix lint

* Fix missing error->text change

* fix openAppsModal references

* lint, types, and i18n

* lint

* missing method

* update snapshots

* Fixed handleBindingClick, was double-wrapping .data

* fixed embedded button binding

* various fixes

* fix lookups for command parser

* sync app command parser

* types

* fix tests

* change control flow for cleaning bindings

* re-expand bindings when post is updated

* getDerivedStateFromProps to avoid lint rule

* avoid `this` usage in static function

* fix other spot with same issue

Co-authored-by: Lev Brouk <lev@mattermost.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
diegovega49 pushed a commit to michellejtan/mattermost-webapp that referenced this pull request Aug 12, 2022
AshishDhama pushed a commit that referenced this pull request Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
5 participants