Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-15709 certain aspect ratio of images cause pop on firefox #2826

Merged
merged 2 commits into from
May 22, 2019
Merged

MM-15709 certain aspect ratio of images cause pop on firefox #2826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fa16ac
MM-155703 certain aspect ratio of images cause pop on firefox
sudheerDev May 20, 2019
f085113
remove string convertion and keep maxHeight and maxWidth as numbers
sudheerDev May 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/__snapshots__/size_aware_image.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ exports[`components/SizeAwareImage should render a placeholder and has loader wh
<svg
style={
Object {
"maxHeight": "200",
"maxWidth": "300",
"maxHeight": 200,
"maxWidth": 300,
"verticalAlign": "middle",
}
}
Expand Down
2 changes: 1 addition & 1 deletion components/size_aware_image.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export default class SizeAwareImage extends React.PureComponent {
<svg
xmlns='http://www.w3.org/2000/svg'
viewBox={`0 0 ${dimensions.width} ${dimensions.height}`}
style={{verticalAlign: 'middle', maxHeight: `${dimensions.height}`, maxWidth: `${dimensions.width}`}}
style={{verticalAlign: 'middle', maxHeight: dimensions.height, maxWidth: dimensions.width}}
/>
</div>
);
Expand Down