Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e/runTests.js
Outdated
@@ -0,0 +1,58 @@ | |||
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change filename to e2e/run_tests.js
@saturninoabril @prapti Everything should be up to date now! |
Should I be looking for the mochawesome-report folder inside e2e/results?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except for non-blocking comments/suggestion.
Probably will not affect others in general, especially those who's not running the full test in local but when they do then run style check (npm run check
), too many errors will come out that's hard to pinpoint that it's from the generated app.js
of mochawesome report. I suggest to add --ignore-pattern e2e/results
to check
script of main package.json
.
.gitignore
Outdated
e2e/cypress/videos | ||
e2e/results | ||
e2e/mochawesome-report | ||
e2e/mochawesome-merged.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's clean this up with the only folders to ignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saturninoabril Pushed up changes to remove those unneeded ignores. Added .eslintignore
file to handle ignoring e2e/results in linting.
* Mochawesome reporting * rename script file, move all results into results folder * Cleanup file ignores * Missed screenshots folder
* Mochawesome reporting * rename script file, move all results into results folder * Cleanup file ignores * Missed screenshots folder
Summary
Use the cypress module to configure cypress and run tests programatically
Integrate mochawesome reports (pretty HTML reports, with integrated screenshots)
To run, just do
npm run test
, afterwards you should have a mochawesome-report directory. If you open up mochawesome.html in your browser, you can view the report.Ticket Link
JIRA