This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-15943 render divider before plugin menu items #3264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems I commited some changes to |
jasonblais
added
1: PM Review
aaronrothschild
approved these changes
Jul 26, 2019
asaadmahmood
approved these changes
Jul 27, 2019
cpoile
added
4: Reviews Complete
cpoile
added
2: Dev Review
|
If no changes to the package.json file there should not be changes to the lock file |
|
Removed unnecessary changes to |
saturninoabril
suggested changes
Aug 5, 2019
There was a problem hiding this comment.
Thanks @janvt! Done UI check and looks good. Left comment on unit test.
| @@ -315,6 +315,12 @@ export default class DotMenu extends Component { | |||
| text={Utils.localizeMessage('post_info.edit', 'Edit')} | |||
| onClick={this.handleEditMenuItemActivated} | |||
| /> | |||
| {pluginItems.length > 0 && | |||
| <li | |||
There was a problem hiding this comment.
Please add id for testing, like id='menuItemDivider'
| expect(wrapper.find('#divider_post_post_post_id_1').exists()).toBe(false); | ||
|
|
||
| wrapper.setProps({pluginMenuItems: [{id: 'test_plugin_menu_item_1', text: 'woof'}]}); | ||
| expect(wrapper.find('#divider_post_post_post_id_1').length).toBe(1); |
There was a problem hiding this comment.
This is failing on test. Element ID should be divider_post_post_id_1. Also please update to master.
Let me know once updated so we can merge. Thanks!
|
@janvt Let me know if you need help. I can update the test if you don't mind so we can merge it. |
|
@saturninoabril yeah, that would be awesome. I've taken 2 runs at it, but not sure what I'm not understanding... :D |
saturninoabril
approved these changes
Aug 22, 2019
saturninoabril
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
* MM-15943 render divider before plugin menu items * revert changes to package-lock.json * adjust dot menu unit test, remove dedicated plugin divider test * fix test as suggested
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
* MM-15943 render divider before plugin menu items * revert changes to package-lock.json * adjust dot menu unit test, remove dedicated plugin divider test * fix test as suggested
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Render divider between normal menu items and plugin menu items on dot menu.
Ticket Link
Fixes mattermost/mattermost#11054
https://mattermost.atlassian.net/browse/MM-15943
Related Pull Requests
mattermost/mattermost-plugin-jira#250