Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-17975] Updating redux hash #3592

Merged
merged 1 commit into from Sep 4, 2019
Merged

[MM-17975] Updating redux hash #3592

merged 1 commit into from Sep 4, 2019

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Sep 3, 2019

Summary

Ticket Link

MM-17975

Related Pull Requests

@cpoile cpoile added the 2: Dev Review Requires review by a core commiter label Sep 3, 2019
Copy link
Member

@crspeller crspeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the package-lock is fine. I don't understand why it changes all the time.

@sudheerDev
Copy link
Contributor

Updating the package-lock is fine. I don't understand why it changes all the time.

Happens whenever the npm install is run after the package-lock is updated from a different platform.

I don't know the platform @cpoile is on but if he is on mac then someone on windows after merging this will have similar updates to lock file with removal of the optional flags.

I don't know the solution to this.

@sudheerDev sudheerDev added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Sep 4, 2019
@cpoile cpoile merged commit 8757db0 into mattermost:master Sep 4, 2019
@cpoile cpoile deleted the MM-17975 branch September 4, 2019 17:20
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Sep 17, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation
Projects
None yet
4 participants