Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-21558: Add Invite More button #4648

Merged
merged 5 commits into from Jan 23, 2020
Merged

MM-21558: Add Invite More button #4648

merged 5 commits into from Jan 23, 2020

Conversation

sbishel
Copy link
Member

@sbishel sbishel commented Jan 10, 2020

Summary

Adds an new button to the invitation_modal_confirm_step that allows the administrator to return to the initial step and add more members/guests

Ticket Link

https://mattermost.atlassian.net/browse/MM-21558

Screenshots

Screen Shot 2020-01-09 at 9 52 05 AM

@sbishel sbishel added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Jan 10, 2020
@sbishel sbishel added this to the v5.20.0 milestone Jan 10, 2020
jespino
jespino approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srkgupta srkgupta added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Jan 13, 2020
@mattermod
Copy link
Contributor

Test server destroyed

srkgupta
srkgupta suggested changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sbishel
The changes are looking good. Can you please add a Cypress test to verify Invite More button functionality in Invite Members & Invite Guest flow.

mkraft
mkraft approved these changes Jan 14, 2020
View reviewed changes
components/invitation_modal/invitation_modal_confirm_step.scss Outdated
padding: 13px 20px;
border: 1px solid;
background: var(--center-channel-bg);
color: var(--button-bg);;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
color: var(--button-bg);;
color: var(--button-bg);

@amyblais amyblais removed this from the v5.20.0 milestone Jan 17, 2020
@sbishel sbishel requested a review from srkgupta January 22, 2020 01:21
srkgupta
srkgupta approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbishel. Tested the changes locally and the feature is working fine. Testcase has been added to the release spreadsheet and the Cypress test has been included by @sbishel

@srkgupta srkgupta added 4: Reviews Complete All reviewers have approved the pull request QA Review Done and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Jan 23, 2020
@srkgupta srkgupta added this to the v5.22.0 milestone Jan 23, 2020
@srkgupta srkgupta merged commit bb2ac30 into mattermost:master Jan 23, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Mar 13, 2020
@sbishel sbishel deleted the MM-21558 branch June 1, 2020 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jespino jespino jespino approved these changes

@mkraft mkraft mkraft approved these changes

@srkgupta srkgupta srkgupta approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
Milestone
v5.22.0
6 participants
@sbishel @mattermod @jespino @mkraft @srkgupta @amyblais