Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-24436]- Add a threshold from bottom for new messages toast #5828

Merged
merged 12 commits into from
Oct 14, 2020
Merged

[MM-24436]- Add a threshold from bottom for new messages toast #5828

merged 12 commits into from
Oct 14, 2020
+39 −20

Commits on Oct 13, 2020

  1. Changed the buffer value to be considered from bottom for the toast m… 

    …essage
    @sridhar02
    sridhar02 committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    12061bd View commit details
    Browse the repository at this point in the history

  2. test value changes related to isAtBottom function

    @sridhar02
    sridhar02 committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    9f83968 View commit details
    Browse the repository at this point in the history

  3. Changes are set to previous values as this is not right approach

    @sridhar02
    sridhar02 committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    c86b515 View commit details
    Browse the repository at this point in the history

  4. added the condition for the offset from bottom greater than 1000px

    @sridhar02
    sridhar02 committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    895a868 View commit details
    Browse the repository at this point in the history

  5. Change the test conditions according to new condition to show the toa… 

    …st message
    @sridhar02
    sridhar02 committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    67b0848 View commit details
    Browse the repository at this point in the history

  6. logic change

    @sridhar02
    sridhar02 committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    f6f6454 View commit details
    Browse the repository at this point in the history

  7. eslint corrections

    @sridhar02
    sridhar02 committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    0fafa05 View commit details
    Browse the repository at this point in the history

  8. added a test that fails if the scroll from bottom is less than 1000px

    @sridhar02
    sridhar02 committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    5668baa View commit details
    Browse the repository at this point in the history

  9. add constant THRESHOLD_FROM_BOTTOM and replace 1000 value

    @sridhar02
    sridhar02 committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    a0afef1 View commit details
    Browse the repository at this point in the history

  10. Bug fix for toast flashing when you mark as unread

    @sridhar02
    sridhar02 committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    804ef42 View commit details
    Browse the repository at this point in the history

  11. bug fix

    @sridhar02
    sridhar02 committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    9e35e46 View commit details
    Browse the repository at this point in the history

  12. tests resolved

    @sridhar02
    sridhar02 committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    91597ca View commit details
    Browse the repository at this point in the history