This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-20455] Migrate 'components/integrations/edit_incoming_webhook' module and associated tests to TypeScript #6596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hook-ts Sync branch
hanzei
added
2: Dev Review
devinbinnie
approved these changes
Oct 1, 2020
larkox
suggested changes
Oct 5, 2020
DHaussermann
added
the
Setup Cloud Test Server
DHaussermann
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
Tested and passed
- CRUD tested backstage UI for incoming webhooks
- No functional issues foung or JS console errors seen
- Tested on Chrome and desktop
LGTM!
Thanks @didithilmy for this improvement!
DHaussermann
added
4: Reviews Complete
|
Test server destroyed |
|
/update-branch |
|
Thanks for the contribution @didithilmy. Looking forward to another more 🚀 |
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
…dule and associated tests to TypeScript (#6596)
calebroseland
pushed a commit
that referenced
this pull request
Oct 27, 2020
…dule and associated tests to TypeScript (#6596)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the following files to TypeScript:
components/integrations/edit_incoming_webhook/index.tscomponents/integrations/edit_incoming_webhook/edit_incoming_webhook.tsxcomponents/integrations/edit_incoming_webhook/edit_incoming_webhook.test.tsxTicket Link
Fixes mattermost/mattermost#15485
Related Pull Requests
None
Screenshots
None