This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-20480] Migrate new_message_separator and its tests to typescript #6636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @abdusabri, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
abdusabri
changed the title
jasonblais
added
3: QA Review
lindy65
added
the
Setup Cloud Test Server
lindy65
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
Thanks @abdusabri - tested around new messages separator and looks good to me 👍
@sudheerDev - please resolve associated Jira ticket after merge - thanks!
lindy65
added
4: Reviews Complete
|
Test server destroyed |
|
/update-branch |
|
Thanks for yet another contribution @abdusabri. Glad you are continuously contributing 🚀 |
Thanks Ben! Happy to help 😊 |
amyblais
added
Changelog/Not Needed
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
calebroseland
pushed a commit
that referenced
this pull request
Oct 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
new_message_separatormodule and its tests to TypeScript.Ticket Link
Fixes mattermost/mattermost#15461, https://mattermost.atlassian.net/browse/MM-20480