Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Migrate 'components/claim' module and associated tests to TypeScript #7043

Merged
merged 3 commits into from Nov 25, 2020
Merged

Migrate 'components/claim' module and associated tests to TypeScript #7043

merged 3 commits into from Nov 25, 2020

Conversation

katyasichov
Copy link
Contributor

@katyasichov katyasichov commented Nov 9, 2020 •
edited

Summary

Migrate 'components/claim' module and associated tests to TypeScript

Ticket Link

Fixes mattermost/mattermost#16144

@mattermod
Copy link
Contributor

Hello @egrinberg,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@katyasichov katyasichov mentioned this pull request Nov 10, 2020
Closed
1 task
@hanzei hanzei added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Nov 10, 2020
hanzei
hanzei reviewed Nov 10, 2020
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR 🎉 One request before we kick of reviews.

package-lock.json Outdated Show resolved Hide resolved
Willyfrog
Willyfrog suggested changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@Willyfrog Willyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, but some minor changes, thanks!

components/claim/claim_controller.tsx Outdated Show resolved Hide resolved
components/claim/claim_controller.tsx Outdated Show resolved Hide resolved
Willyfrog
Willyfrog approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@Willyfrog Willyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you!!

@Willyfrog
Copy link
Contributor

/update-branch

@jgilliam17 jgilliam17 added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Nov 20, 2020
jgilliam17
jgilliam17 approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@jgilliam17 jgilliam17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @egrinberg
Tested, looks good to merge.

  • Verified setting up account around third party auth.
    QA will test further after merge as some sys. console settings around LDAP are set to true by default through env. variable.

@jgilliam17 jgilliam17 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Nov 24, 2020
@mm-cloud-bot
Copy link

Test server destroyed

@Willyfrog
Copy link
Contributor

/update-branch

@Willyfrog Willyfrog added the AutoMerge used by Mattermod to merge PR automatically label Nov 25, 2020
@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@mattermod
Copy link
Contributor

Trying to auto merge this PR.

@mattermod mattermod merged commit ffd1256 into mattermost:master Nov 25, 2020
@mattermod
Copy link
Contributor

Pull Request successfully merged
SHA: ffd1256

@mattermod mattermod removed the AutoMerge used by Mattermod to merge PR automatically label Nov 25, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hanzei hanzei hanzei left review comments

@Willyfrog Willyfrog Willyfrog approved these changes

@nevyangelova nevyangelova nevyangelova approved these changes

@jgilliam17 jgilliam17 jgilliam17 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
8 participants
@katyasichov @mattermod @Willyfrog @mm-cloud-bot @hanzei @nevyangelova @jgilliam17 @amyblais