Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-30852 Add ellipses to text overflow in system console users list #7534

Closed
wants to merge 3 commits into from

Conversation

anurag6713
Copy link
Contributor

Summary

Excessively long first and last names push member link nearly off right side of user list. This PR horizontal scroll and adds ellipses to text.

Ticket Link

https://mattermost.atlassian.net/browse/MM-30852

Screenshots

Screenshot 2021-02-17 at 12 04 57

Screenshot 2021-02-17 at 12 04 18

@anurag6713 anurag6713 added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester 1: UX Review Requires review by a UX Designer labels Feb 17, 2021
@anurag6713 anurag6713 marked this pull request as ready for review February 17, 2021 06:44
@anurag6713
Copy link
Contributor Author

/update-branch

@calebroseland calebroseland added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Feb 23, 2021
Copy link
Member

@calebroseland calebroseland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✓

(UI-wise, the vertical alignment is (was already) a bit off, and the '...' is a slightly different color, but these might be better taken up in a separate ticket)

CleanShot 2021-02-23 at 17 28 32@2x

@calebroseland calebroseland removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Feb 23, 2021
@furqanmlk
Copy link
Contributor

/update-branch

@furqanmlk furqanmlk added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Mar 12, 2021
Copy link
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When First and Last name is longer,
User ID: is missing on User Card

image

@furqanmlk
Copy link
Contributor

Updated the Jira ticket

https://mattermost.atlassian.net/browse/MM-30852

@angeloskyratzakos
Copy link
Contributor

Hey all, I will remove the tag Setup Cloud Test Server for maintenance reasons. Feel free to re-add it when you need it. Thank you

@angeloskyratzakos angeloskyratzakos removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jun 3, 2021
@mm-cloud-bot
Copy link

Test server destroyed

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@mm-cloud-bot
Copy link

@anurag6713: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@lieut-data
Copy link
Member

lieut-data commented Mar 2, 2023

Heads up that as part of our efforts to move to a monorepo, we're closing out a number of older pull requests like this one to help streamline the effort.

If you'd like to preserve these changes -- even if you're not the original author! -- feel free to resubmit the pull request against the monorepo once it's ready. You can subscribe to mattermost-server-issue-22420 for status updates on this effort.

@lieut-data lieut-data closed this Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1: UX Review Requires review by a UX Designer 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester do-not-merge/release-note-label-needed Lifecycle/1:stale
Projects
None yet
9 participants