Skip to content

Commit

Permalink
Temporary disabling .pages indexing to avoid crashes on malicious fil…
Browse files Browse the repository at this point in the history
…es (#19436) (#19482)

Automatic Merge
  • Loading branch information
mattermost-build committed Feb 2, 2022
1 parent a21327a commit 35c5010
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions services/docextractor/documents.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,15 @@ import (
type documentExtractor struct{}

var doconvConverterByExtensions = map[string]func(io.Reader) (string, map[string]string, error){
"doc": docconv.ConvertDoc,
"docx": docconv.ConvertDocx,
"pptx": docconv.ConvertPptx,
"odt": docconv.ConvertODT,
"html": func(r io.Reader) (string, map[string]string, error) { return docconv.ConvertHTML(r, true) },
"pages": docconv.ConvertPages,
"rtf": docconv.ConvertRTF,
"pdf": docconv.ConvertPDF,
"doc": docconv.ConvertDoc,
"docx": docconv.ConvertDocx,
"pptx": docconv.ConvertPptx,
"odt": docconv.ConvertODT,
"html": func(r io.Reader) (string, map[string]string, error) { return docconv.ConvertHTML(r, true) },
// Temporarily disabled to avoid crashes on malicious .pages files
// "pages": docconv.ConvertPages,
"rtf": docconv.ConvertRTF,
"pdf": docconv.ConvertPDF,
}

func (de *documentExtractor) Match(filename string) bool {
Expand Down

0 comments on commit 35c5010

Please sign in to comment.