playbooks rhs participants: fix infinite fetch loop

mattermost · May 23, 2023 · 6c7cea9 · 6c7cea9
1 parent 8b0ebec
commit 6c7cea9
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/webapp/playbooks/src/components/backstage/playbook_runs/playbook_run/rhs_participants.tsx b/webapp/playbooks/src/components/backstage/playbook_runs/playbook_run/rhs_participants.tsx
@@ -56,18 +56,18 @@ export const Participants = ({playbookRun, role, teamName}: Props) => {
     };
 
     useEffect(() => {
+        if (!playbookRun) {
+            return;
+        }
+
         const profiles = dispatch(getProfilesByIds(playbookRun.participant_ids));
 
         //@ts-ignore
         profiles.then(({data}: { data: UserProfile[] }) => {
-            // getProfilesByIds doesn't return current user profile, so add it when a user is participant
-            if (role === Role.Participant) {
-                data.push(myUser);
-            }
             data.sort(sortByUsername);
             setParticipantsProfiles(data || []);
         });
-    }, [dispatch, myUser, playbookRun.participant_ids, role]);
+    }, [dispatch, playbookRun, playbookRun.participant_ids, role]);
 
     const includesTerm = (user: UserProfile) => {
         const userInfo = user.first_name + ';' + user.last_name + ';' + user.nickname + ';' + user.username;