Migrate tests for Login to Testing Library and convert showNotificati…

…on to a thunk (#26848)

* Migrate tests for Login to Testing Library

* Convert showNotification to a thunk

webapp/channels/src/actions/notification_actions.jsx

@@ -48,7 +48,7 @@ const getNotificationSoundFromChannelMemberAndUser = (member, user) => {
 };
 
 /**
- * @returns {import('mattermost-redux/types/actions').ThunkActionFunc<Promise<NotificationResult>, GlobalState>}
+ * @returns {import('mattermost-redux/types/actions').ThunkActionFunc<Promise<import('utils/notifications').NotificationResult>, GlobalState>}
  */
 export function sendDesktopNotification(post, msgProps) {
     return async (dispatch, getState) => {
@@ -325,14 +325,17 @@ export function sendDesktopNotification(post, msgProps) {
     };
 }
 
+/**
+ * @returns {import('mattermost-redux/types/actions').ThunkActionFunc<Promise<import('utils/notifications').NotificationResult>, GlobalState>}
+ */
 export const notifyMe = (title, body, channel, teamId, silent, soundName, url) => async (dispatch) => {
     // handle notifications in desktop app
     if (isDesktopApp()) {
         return DesktopApp.dispatchNotification(title, body, channel.id, teamId, silent, soundName, url);
     }
 
     try {
-        return await showNotification({
+        return await dispatch(showNotification({
             title,
             body,
             requireInteraction: false,
@@ -341,7 +344,7 @@ export const notifyMe = (title, body, channel, teamId, silent, soundName, url) =
                 window.focus();
                 getHistory().push(url);
             },
-        });
+        }));
     } catch (error) {
         dispatch(logError(error));
         return {status: 'error', reason: 'notification_api', data: String(error)};