Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to override ephemeral posts #10797

Closed
esethna opened this issue May 6, 2019 · 6 comments · Fixed by mattermost/mattermost-webapp#2759
Closed

Allow plugins to override ephemeral posts #10797

esethna opened this issue May 6, 2019 · 6 comments · Fixed by mattermost/mattermost-webapp#2759
Labels
Area/Integrations A mattermost integration (plugin, integration, etc) Difficulty/2:Medium Medium ticket Help Wanted Community help wanted PR Exists Tech/ReactJS Web app

Comments

@esethna
Copy link
Contributor

esethna commented May 6, 2019

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.


Notes: Jira ticket

Mattermost supports plugins that offer powerful features for extending and deeply integrating with both the server and web/desktop apps: https://developers.mattermost.com/extend/plugins/

Currently, plugins can override a regular message posted to a channel using registerPostTypeComponent - this allows a webapp plugin to render a custom body for posts with a specific type prefixed with 'custom_'.

The proposed change is to make this component work with ephemeral posts as well, which are only visible to the user.

A sample use case is for our Mattermost GitHub plugin, where "/github todo" returns an ephemeral message with items to do in GitHub. We would like to replace the resulting message with a custom UI instead of the hard to read Markdown list it is today, as attached below.

image

If you have any questions about the proposed change, ask jasonblais or hanzei on this GitHub issue, or message them on https://community.mattermost.com.

@esethna esethna added the Help Wanted Community help wanted label May 6, 2019
@jasonblais
Copy link
Contributor

@hanzei can you help add the appropriate labels for this ticket?

@hanzei hanzei added Area/Integrations A mattermost integration (plugin, integration, etc) Difficulty/2:Medium Medium ticket Tech/ReactJS Web app Up For Grabs labels May 6, 2019
@hanzei
Copy link
Contributor

hanzei commented May 6, 2019

@jasonblais Done

@scottleedavis
Copy link
Contributor

I'd like to try this one @hanzei @jasonblais :)

@hanzei
Copy link
Contributor

hanzei commented May 8, 2019

Greet! 🚀 Thanks for all your work, Scott!

@jwilander jwilander changed the title Allow plugins override ephemeral posts Allow plugins to override ephemeral posts May 10, 2019
@hanzei
Copy link
Contributor

hanzei commented Jun 19, 2019

Hey @scottleedavis,

I'm wondering if you would be interested in submitting a PR to the demo plugin that makes use of this new feature? Would be cool to show this new possibility in the plugin.

@scottleedavis
Copy link
Contributor

Sounds great @hanzei , will do. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/Integrations A mattermost integration (plugin, integration, etc) Difficulty/2:Medium Medium ticket Help Wanted Community help wanted PR Exists Tech/ReactJS Web app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants